[GitHub] sohami commented on a change in pull request #1600: DRILL-6947: fix RuntimeFilter memory leak

[GitBox <gi...@apache.org>]

sohami commented on a change in pull request #1600: DRILL-6947: fix RuntimeFilter memory leak
URL: https://github.com/apache/drill/pull/1600#discussion_r249888648
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContextImpl.java
 ##########
 @@ -530,11 +530,11 @@ public void close() {
     // Close the buffers before closing the operators; this is needed as buffer ownership
     // is attached to the receive operators.
     suppressingClose(buffers);
-    closeNotConsumedRFWs();
     // close operator context
     for (OperatorContextImpl opContext : contexts) {
       suppressingClose(opContext);
     }
+    closeNotConsumedRFWs();
 
 Review comment:
   I see that all the bloomFilters of RFW are allocated using [fragment context allocator](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java#L836) not operator context so why does the order in which `closeNotConsumedRFWs()` is called matters here ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services