You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2015/03/04 14:17:10 UTC
svn commit: r1663983 - /ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
Author: jleroux
Date: Wed Mar 4 13:17:09 2015
New Revision: 1663983
URL: http://svn.apache.org/r1663983
Log:
A patch from Pierre Smits for "Have BIRT reporting component visible in secondary app menu" https://issues.apache.org/jira/browse/OFBIZ-6122
Currently the birt reporting component is not visible in the main menu of OFBiz, thereby hindering the adoption
Modified:
ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
Modified: ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml?rev=1663983&r1=1663982&r2=1663983&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml (original)
+++ ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml Wed Mar 4 13:17:09 2015
@@ -30,33 +30,34 @@ under the License.
<service-resource type="model" loader="main" location="servicedef/services.xml"/>
<webapp name="accounting"
- title="Accounting"
- server="default-server"
- location="webapp/accounting"
- base-permission="OFBTOOLS,ACCOUNTING"
- mount-point="/accounting"/>
+ title="Accounting"
+ server="default-server"
+ location="webapp/accounting"
+ base-permission="OFBTOOLS,ACCOUNTING"
+ mount-point="/accounting"/>
<webapp name="facility"
- title="Facility"
- description="FacilityComponentDescription"
- server="default-server"
- location="webapp/facility"
- base-permission="OFBTOOLS,FACILITY"
- mount-point="/facility"/>
+ title="Facility"
+ description="FacilityComponentDescription"
+ server="default-server"
+ location="webapp/facility"
+ base-permission="OFBTOOLS,FACILITY"
+ mount-point="/facility"/>
<webapp name="order"
- title="Order"
- description="OrderComponentDescription"
- server="default-server"
- location="webapp/ordermgr"
- base-permission="OFBTOOLS,ORDERMGR"
- mount-point="/ordermgr"/>
+ title="Order"
+ description="OrderComponentDescription"
+ server="default-server"
+ location="webapp/ordermgr"
+ base-permission="OFBTOOLS,ORDERMGR"
+ mount-point="/ordermgr"/>
<webapp name="birt"
- title="BIRT"
- server="default-server"
- location="webapp/birt"
- base-permission="OFBTOOLS,WEBTOOLS"
- mount-point="/birt"
- app-bar-display="false"/>
+ title="BIRT"
+ server="default-server"
+ location="webapp/birt"
+ base-permission="OFBTOOLS,WEBTOOLS"
+ mount-point="/birt"
+ menu-name="secondary"
+ app-bar-display="true"/>
<container name="birt-container" loaders="main" class="org.ofbiz.birt.container.BirtContainer"/>
Re: svn commit: r1663983 - /ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
Posted by Pierre Smits <pi...@gmail.com>.
It is not the first time since I started using the Eclipse Luna IDE.
Pierre Smits
*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com
On Wed, Mar 4, 2015 at 3:45 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Yes, it would have been better to be done separatly, but the formatting
> makes sense also, so that was it
>
> The only change is in <webapp name="birt"
> menu-name="secondary"
> app-bar-display="true"/>
>
> Jacques
>
> Le 04/03/2015 14:41, Jacopo Cappellato a écrit :
>
> There are a lot of formatting changes in this commit that hide the actual
>> change.
>>
>> Jacopo
>>
>> On Mar 4, 2015, at 2:17 PM, jleroux@apache.org wrote:
>>
>> Author: jleroux
>>> Date: Wed Mar 4 13:17:09 2015
>>> New Revision: 1663983
>>>
>>> URL: http://svn.apache.org/r1663983
>>> Log:
>>> A patch from Pierre Smits for "Have BIRT reporting component visible in
>>> secondary app menu" https://issues.apache.org/jira/browse/OFBIZ-6122
>>>
>>> Currently the birt reporting component is not visible in the main menu
>>> of OFBiz, thereby hindering the adoption
>>>
>>> Modified:
>>> ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
>>>
>>> Modified: ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/
>>> birt/ofbiz-component.xml?rev=1663983&r1=1663982&r2=1663983&view=diff
>>> ============================================================
>>> ==================
>>> --- ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml (original)
>>> +++ ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml Wed Mar 4
>>> 13:17:09 2015
>>> @@ -30,33 +30,34 @@ under the License.
>>> <service-resource type="model" loader="main"
>>> location="servicedef/services.xml"/>
>>>
>>> <webapp name="accounting"
>>> - title="Accounting"
>>> - server="default-server"
>>> - location="webapp/accounting"
>>> - base-permission="OFBTOOLS,ACCOUNTING"
>>> - mount-point="/accounting"/>
>>> + title="Accounting"
>>> + server="default-server"
>>> + location="webapp/accounting"
>>> + base-permission="OFBTOOLS,ACCOUNTING"
>>> + mount-point="/accounting"/>
>>> <webapp name="facility"
>>> - title="Facility"
>>> - description="FacilityComponentDescription"
>>> - server="default-server"
>>> - location="webapp/facility"
>>> - base-permission="OFBTOOLS,FACILITY"
>>> - mount-point="/facility"/>
>>> + title="Facility"
>>> + description="FacilityComponentDescription"
>>> + server="default-server"
>>> + location="webapp/facility"
>>> + base-permission="OFBTOOLS,FACILITY"
>>> + mount-point="/facility"/>
>>> <webapp name="order"
>>> - title="Order"
>>> - description="OrderComponentDescription"
>>> - server="default-server"
>>> - location="webapp/ordermgr"
>>> - base-permission="OFBTOOLS,ORDERMGR"
>>> - mount-point="/ordermgr"/>
>>> + title="Order"
>>> + description="OrderComponentDescription"
>>> + server="default-server"
>>> + location="webapp/ordermgr"
>>> + base-permission="OFBTOOLS,ORDERMGR"
>>> + mount-point="/ordermgr"/>
>>>
>>> <webapp name="birt"
>>> - title="BIRT"
>>> - server="default-server"
>>> - location="webapp/birt"
>>> - base-permission="OFBTOOLS,WEBTOOLS"
>>> - mount-point="/birt"
>>> - app-bar-display="false"/>
>>> + title="BIRT"
>>> + server="default-server"
>>> + location="webapp/birt"
>>> + base-permission="OFBTOOLS,WEBTOOLS"
>>> + mount-point="/birt"
>>> + menu-name="secondary"
>>> + app-bar-display="true"/>
>>>
>>> <container name="birt-container" loaders="main"
>>> class="org.ofbiz.birt.container.BirtContainer"/>
>>>
>>>
>>>
>>>
>>
>>
Re: svn commit: r1663983 -
/ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes, it would have been better to be done separatly, but the formatting makes sense also, so that was it
The only change is in <webapp name="birt"
menu-name="secondary"
app-bar-display="true"/>
Jacques
Le 04/03/2015 14:41, Jacopo Cappellato a écrit :
> There are a lot of formatting changes in this commit that hide the actual change.
>
> Jacopo
>
> On Mar 4, 2015, at 2:17 PM, jleroux@apache.org wrote:
>
>> Author: jleroux
>> Date: Wed Mar 4 13:17:09 2015
>> New Revision: 1663983
>>
>> URL: http://svn.apache.org/r1663983
>> Log:
>> A patch from Pierre Smits for "Have BIRT reporting component visible in secondary app menu" https://issues.apache.org/jira/browse/OFBIZ-6122
>>
>> Currently the birt reporting component is not visible in the main menu of OFBiz, thereby hindering the adoption
>>
>> Modified:
>> ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
>>
>> Modified: ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml?rev=1663983&r1=1663982&r2=1663983&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml (original)
>> +++ ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml Wed Mar 4 13:17:09 2015
>> @@ -30,33 +30,34 @@ under the License.
>> <service-resource type="model" loader="main" location="servicedef/services.xml"/>
>>
>> <webapp name="accounting"
>> - title="Accounting"
>> - server="default-server"
>> - location="webapp/accounting"
>> - base-permission="OFBTOOLS,ACCOUNTING"
>> - mount-point="/accounting"/>
>> + title="Accounting"
>> + server="default-server"
>> + location="webapp/accounting"
>> + base-permission="OFBTOOLS,ACCOUNTING"
>> + mount-point="/accounting"/>
>> <webapp name="facility"
>> - title="Facility"
>> - description="FacilityComponentDescription"
>> - server="default-server"
>> - location="webapp/facility"
>> - base-permission="OFBTOOLS,FACILITY"
>> - mount-point="/facility"/>
>> + title="Facility"
>> + description="FacilityComponentDescription"
>> + server="default-server"
>> + location="webapp/facility"
>> + base-permission="OFBTOOLS,FACILITY"
>> + mount-point="/facility"/>
>> <webapp name="order"
>> - title="Order"
>> - description="OrderComponentDescription"
>> - server="default-server"
>> - location="webapp/ordermgr"
>> - base-permission="OFBTOOLS,ORDERMGR"
>> - mount-point="/ordermgr"/>
>> + title="Order"
>> + description="OrderComponentDescription"
>> + server="default-server"
>> + location="webapp/ordermgr"
>> + base-permission="OFBTOOLS,ORDERMGR"
>> + mount-point="/ordermgr"/>
>>
>> <webapp name="birt"
>> - title="BIRT"
>> - server="default-server"
>> - location="webapp/birt"
>> - base-permission="OFBTOOLS,WEBTOOLS"
>> - mount-point="/birt"
>> - app-bar-display="false"/>
>> + title="BIRT"
>> + server="default-server"
>> + location="webapp/birt"
>> + base-permission="OFBTOOLS,WEBTOOLS"
>> + mount-point="/birt"
>> + menu-name="secondary"
>> + app-bar-display="true"/>
>>
>> <container name="birt-container" loaders="main" class="org.ofbiz.birt.container.BirtContainer"/>
>>
>>
>>
>
>
Re: svn commit: r1663983 - /ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
Posted by Pierre Smits <pi...@gmail.com>.
Hmm....
I assure you it was unintentionally. But I will pay more attention next
time regarding the patches I add to issues.
Best regards,
Pierre Smits
*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com
On Wed, Mar 4, 2015 at 2:41 PM, Jacopo Cappellato <
jacopo.cappellato@hotwaxsystems.com> wrote:
> There are a lot of formatting changes in this commit that hide the actual
> change.
>
> Jacopo
>
> On Mar 4, 2015, at 2:17 PM, jleroux@apache.org wrote:
>
> > Author: jleroux
> > Date: Wed Mar 4 13:17:09 2015
> > New Revision: 1663983
> >
> > URL: http://svn.apache.org/r1663983
> > Log:
> > A patch from Pierre Smits for "Have BIRT reporting component visible in
> secondary app menu" https://issues.apache.org/jira/browse/OFBIZ-6122
> >
> > Currently the birt reporting component is not visible in the main menu
> of OFBiz, thereby hindering the adoption
> >
> > Modified:
> > ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
> >
> > Modified: ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
> > URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml?rev=1663983&r1=1663982&r2=1663983&view=diff
> >
> ==============================================================================
> > --- ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml (original)
> > +++ ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml Wed Mar 4
> 13:17:09 2015
> > @@ -30,33 +30,34 @@ under the License.
> > <service-resource type="model" loader="main"
> location="servicedef/services.xml"/>
> >
> > <webapp name="accounting"
> > - title="Accounting"
> > - server="default-server"
> > - location="webapp/accounting"
> > - base-permission="OFBTOOLS,ACCOUNTING"
> > - mount-point="/accounting"/>
> > + title="Accounting"
> > + server="default-server"
> > + location="webapp/accounting"
> > + base-permission="OFBTOOLS,ACCOUNTING"
> > + mount-point="/accounting"/>
> > <webapp name="facility"
> > - title="Facility"
> > - description="FacilityComponentDescription"
> > - server="default-server"
> > - location="webapp/facility"
> > - base-permission="OFBTOOLS,FACILITY"
> > - mount-point="/facility"/>
> > + title="Facility"
> > + description="FacilityComponentDescription"
> > + server="default-server"
> > + location="webapp/facility"
> > + base-permission="OFBTOOLS,FACILITY"
> > + mount-point="/facility"/>
> > <webapp name="order"
> > - title="Order"
> > - description="OrderComponentDescription"
> > - server="default-server"
> > - location="webapp/ordermgr"
> > - base-permission="OFBTOOLS,ORDERMGR"
> > - mount-point="/ordermgr"/>
> > + title="Order"
> > + description="OrderComponentDescription"
> > + server="default-server"
> > + location="webapp/ordermgr"
> > + base-permission="OFBTOOLS,ORDERMGR"
> > + mount-point="/ordermgr"/>
> >
> > <webapp name="birt"
> > - title="BIRT"
> > - server="default-server"
> > - location="webapp/birt"
> > - base-permission="OFBTOOLS,WEBTOOLS"
> > - mount-point="/birt"
> > - app-bar-display="false"/>
> > + title="BIRT"
> > + server="default-server"
> > + location="webapp/birt"
> > + base-permission="OFBTOOLS,WEBTOOLS"
> > + mount-point="/birt"
> > + menu-name="secondary"
> > + app-bar-display="true"/>
> >
> > <container name="birt-container" loaders="main"
> class="org.ofbiz.birt.container.BirtContainer"/>
> >
> >
> >
>
>
Re: svn commit: r1663983 - /ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
Posted by Jacopo Cappellato <ja...@hotwaxsystems.com>.
There are a lot of formatting changes in this commit that hide the actual change.
Jacopo
On Mar 4, 2015, at 2:17 PM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Wed Mar 4 13:17:09 2015
> New Revision: 1663983
>
> URL: http://svn.apache.org/r1663983
> Log:
> A patch from Pierre Smits for "Have BIRT reporting component visible in secondary app menu" https://issues.apache.org/jira/browse/OFBIZ-6122
>
> Currently the birt reporting component is not visible in the main menu of OFBiz, thereby hindering the adoption
>
> Modified:
> ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
>
> Modified: ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml?rev=1663983&r1=1663982&r2=1663983&view=diff
> ==============================================================================
> --- ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml (original)
> +++ ofbiz/trunk/specialpurpose/birt/ofbiz-component.xml Wed Mar 4 13:17:09 2015
> @@ -30,33 +30,34 @@ under the License.
> <service-resource type="model" loader="main" location="servicedef/services.xml"/>
>
> <webapp name="accounting"
> - title="Accounting"
> - server="default-server"
> - location="webapp/accounting"
> - base-permission="OFBTOOLS,ACCOUNTING"
> - mount-point="/accounting"/>
> + title="Accounting"
> + server="default-server"
> + location="webapp/accounting"
> + base-permission="OFBTOOLS,ACCOUNTING"
> + mount-point="/accounting"/>
> <webapp name="facility"
> - title="Facility"
> - description="FacilityComponentDescription"
> - server="default-server"
> - location="webapp/facility"
> - base-permission="OFBTOOLS,FACILITY"
> - mount-point="/facility"/>
> + title="Facility"
> + description="FacilityComponentDescription"
> + server="default-server"
> + location="webapp/facility"
> + base-permission="OFBTOOLS,FACILITY"
> + mount-point="/facility"/>
> <webapp name="order"
> - title="Order"
> - description="OrderComponentDescription"
> - server="default-server"
> - location="webapp/ordermgr"
> - base-permission="OFBTOOLS,ORDERMGR"
> - mount-point="/ordermgr"/>
> + title="Order"
> + description="OrderComponentDescription"
> + server="default-server"
> + location="webapp/ordermgr"
> + base-permission="OFBTOOLS,ORDERMGR"
> + mount-point="/ordermgr"/>
>
> <webapp name="birt"
> - title="BIRT"
> - server="default-server"
> - location="webapp/birt"
> - base-permission="OFBTOOLS,WEBTOOLS"
> - mount-point="/birt"
> - app-bar-display="false"/>
> + title="BIRT"
> + server="default-server"
> + location="webapp/birt"
> + base-permission="OFBTOOLS,WEBTOOLS"
> + mount-point="/birt"
> + menu-name="secondary"
> + app-bar-display="true"/>
>
> <container name="birt-container" loaders="main" class="org.ofbiz.birt.container.BirtContainer"/>
>
>
>