You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/31 13:07:59 UTC

[GitHub] [incubator-inlong] woofyzhao opened a new pull request, #4465: [INLONG-4464][Manager] Fix various problems emerged from full link path tests.

woofyzhao opened a new pull request, #4465:
URL: https://github.com/apache/incubator-inlong/pull/4465

   - Fixes #4464
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4465: [INLONG-4464][Manager] Fix problems emerged from full link path tests

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4465:
URL: https://github.com/apache/incubator-inlong/pull/4465#discussion_r887774178


##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/FieldType.java:
##########
@@ -42,7 +42,7 @@ public enum FieldType {
     public static FieldType forName(String name) {
         Preconditions.checkNotNull(name, "FieldType should not be null");
         for (FieldType value : values()) {
-            if (value.toString().equals(name)) {
+            if (value.toString().equalsIgnoreCase(name)) {

Review Comment:
   I checked again, and this scenario needs ignore case, please change it back, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] woofyzhao commented on a diff in pull request #4465: [INLONG-4464][Manager] Fix problems emerged from full link path tests

Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #4465:
URL: https://github.com/apache/incubator-inlong/pull/4465#discussion_r887422179


##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/FieldType.java:
##########
@@ -42,7 +42,7 @@ public enum FieldType {
     public static FieldType forName(String name) {
         Preconditions.checkNotNull(name, "FieldType should not be null");
         for (FieldType value : values()) {
-            if (value.toString().equals(name)) {
+            if (value.toString().equalsIgnoreCase(name)) {

Review Comment:
   OK. Dashboard needs to be fixed then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] dockerzhang merged pull request #4465: [INLONG-4464][Manager] Fix problems emerged from full link path tests

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4465:
URL: https://github.com/apache/incubator-inlong/pull/4465


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4465: [INLONG-4464][Manager] Fix problems emerged from full link path tests.

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4465:
URL: https://github.com/apache/incubator-inlong/pull/4465#discussion_r886734811


##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/FieldType.java:
##########
@@ -42,7 +42,7 @@ public enum FieldType {
     public static FieldType forName(String name) {
         Preconditions.checkNotNull(name, "FieldType should not be null");
         for (FieldType value : values()) {
-            if (value.toString().equals(name)) {
+            if (value.toString().equalsIgnoreCase(name)) {

Review Comment:
   Please do not ignore the case, because we need to limit the parameters passed by the user.



##########
inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkOperation.java:
##########
@@ -105,10 +109,15 @@ public void genPath(FlinkInfo flinkInfo, String dataflow) throws Exception {
             throw new Exception(message);
         }
 
-        String jarPath = findFiles(basePath, SORT_JAR_PATTERN);
+        String jarPath = findFile(basePath, SORT_JAR_PATTERN);

Review Comment:
   Why not use `FlinkUtils.findFiles` to replace the static import?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org