You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Aditya Kishore (JIRA)" <ji...@apache.org> on 2012/11/02 22:54:11 UTC
[jira] [Created] (HBASE-7089) Allow filter to be specified for Get
from HBase shell
Aditya Kishore created HBASE-7089:
-------------------------------------
Summary: Allow filter to be specified for Get from HBase shell
Key: HBASE-7089
URL: https://issues.apache.org/jira/browse/HBASE-7089
Project: HBase
Issue Type: Improvement
Components: shell
Affects Versions: 0.96.0
Reporter: Aditya Kishore
Assignee: Aditya Kishore
Priority: Minor
Unlike scan, get in HBase shell does not accept FILTER as an argument.
{noformat}
hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
COLUMN CELL
ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
Here is some help for this command:
...
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496085#comment-13496085 ]
Hudson commented on HBASE-7089:
-------------------------------
Integrated in HBase-0.94-security #83 (See [https://builds.apache.org/job/HBase-0.94-security/83/])
HBASE-7089 Allow filter to be specified for Get from HBase shell (Aditya Kishore) (Revision 1405697)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/src/main/ruby/hbase/table.rb
* /hbase/branches/0.94/src/main/ruby/shell/commands/get.rb
* /hbase/branches/0.94/src/test/ruby/hbase/table_test.rb
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: HBASE-7089_94.patch, HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490354#comment-13490354 ]
Lars Hofhansl commented on HBASE-7089:
--------------------------------------
Tried to apply this to 0.94. Patch does not apply cleanly, I futzed around with it a few minutes.
Table._get_internal and Table._scan_internal do not exist in 0.94.
It's not super important to have this in 0.94. If somebody makes a patch for 0.94, I'll commit it :)
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489840#comment-13489840 ]
Hadoop QA commented on HBASE-7089:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551933/HBASE-7089_trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 85 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3215//console
This message is automatically generated.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490343#comment-13490343 ]
Hudson commented on HBASE-7089:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #249 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/249/])
HBASE-7089 Allow filter to be specified for Get from HBase shell (Revision 1405640)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/ruby/hbase/table.rb
* /hbase/trunk/hbase-server/src/main/ruby/shell/commands/get.rb
* /hbase/trunk/hbase-server/src/test/ruby/hbase/table_test.rb
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490088#comment-13490088 ]
Hadoop QA commented on HBASE-7089:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551989/HBASE-7089_trunk_v4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 85 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3222//console
This message is automatically generated.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7089) Allow filter to be specified for Get
from HBase shell
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-7089:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Aditya.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490090#comment-13490090 ]
Ted Yu commented on HBASE-7089:
-------------------------------
+1 on patch v4.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7089) Allow filter to be specified for Get
from HBase shell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7089:
---------------------------------
Fix Version/s: 0.94.3
Thanks Aditya, committed to 0.94 as well.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: HBASE-7089_94.patch, HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489830#comment-13489830 ]
Aditya Kishore commented on HBASE-7089:
---------------------------------------
Trying to figure out how to run ruby tests. Will attach the updated patch with the tests (for both get and scan) soon.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7089) Allow filter to be specified for Get
from HBase shell
Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aditya Kishore updated HBASE-7089:
----------------------------------
Attachment: HBASE-7089_trunk_v3.patch
Updated patch with test cases
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490029#comment-13490029 ]
Ted Yu commented on HBASE-7089:
-------------------------------
Tests look good.
nit:
{code}
+ define_test "get should support FILTERS" do
{code}
Why plural form is used above ?
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489808#comment-13489808 ]
stack commented on HBASE-7089:
------------------------------
Should you update the help for Get too Aditya?
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489928#comment-13489928 ]
Hadoop QA commented on HBASE-7089:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551942/HBASE-7089_trunk_v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 85 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3217//console
This message is automatically generated.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7089) Allow filter to be specified for Get
from HBase shell
Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aditya Kishore updated HBASE-7089:
----------------------------------
Attachment: HBASE-7089_trunk_v4.patch
Thanks for reviewing Ted.
bq.Why plural form is used above ?
I used plural because a combination of filters could be specified but now I see that the convention in the test is to use the parameter verbatim.
Attaching new patch with corrections.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7089) Allow filter to be specified for Get
from HBase shell
Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aditya Kishore updated HBASE-7089:
----------------------------------
Attachment: HBASE-7089_94.patch
Oh forgot about the function rename! Here is the one for 0.94 branch.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_94.patch, HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490334#comment-13490334 ]
Hudson commented on HBASE-7089:
-------------------------------
Integrated in HBase-TRUNK #3513 (See [https://builds.apache.org/job/HBase-TRUNK/3513/])
HBASE-7089 Allow filter to be specified for Get from HBase shell (Revision 1405640)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/hbase-server/src/main/ruby/hbase/table.rb
* /hbase/trunk/hbase-server/src/main/ruby/shell/commands/get.rb
* /hbase/trunk/hbase-server/src/test/ruby/hbase/table_test.rb
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489826#comment-13489826 ]
Ted Yu commented on HBASE-7089:
-------------------------------
I looked at hbase-server/src/test/ruby/hbase/table_test.rb where tests for scan don't cover Filter.
Adding test for Filter would be nice.
But I am fine without additional test(s).
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7089) Allow filter to be specified for Get
from HBase shell
Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aditya Kishore updated HBASE-7089:
----------------------------------
Attachment: HBASE-7089_trunk.patch
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Attachments: HBASE-7089_trunk.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489958#comment-13489958 ]
Hadoop QA commented on HBASE-7089:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551972/HBASE-7089_trunk_v3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 85 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3220//console
This message is automatically generated.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7089) Allow filter to be specified for Get
from HBase shell
Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aditya Kishore updated HBASE-7089:
----------------------------------
Fix Version/s: 0.96.0
Status: Patch Available (was: Open)
Submitting patch for trunk.
With this, get now accept filters.
{noformat}
hbase(main):004:0> get 't2', 'r1', {FILTER => "ValueFilter (=, 'binary:valueX')"}
COLUMN CELL
cf:c timestamp=1348831499385, value=valueX
cf:t timestamp=1348831478941, value=valueX
2 row(s) in 11.0770 seconds
{noformat}
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7089) Allow filter to be specified for
Get from HBase shell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490490#comment-13490490 ]
Hudson commented on HBASE-7089:
-------------------------------
Integrated in HBase-0.94 #573 (See [https://builds.apache.org/job/HBase-0.94/573/])
HBASE-7089 Allow filter to be specified for Get from HBase shell (Aditya Kishore) (Revision 1405697)
Result = FAILURE
larsh :
Files :
* /hbase/branches/0.94/src/main/ruby/hbase/table.rb
* /hbase/branches/0.94/src/main/ruby/shell/commands/get.rb
* /hbase/branches/0.94/src/test/ruby/hbase/table_test.rb
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: HBASE-7089_94.patch, HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch, HBASE-7089_trunk_v3.patch, HBASE-7089_trunk_v4.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7089) Allow filter to be specified for Get
from HBase shell
Posted by "Aditya Kishore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aditya Kishore updated HBASE-7089:
----------------------------------
Attachment: HBASE-7089_trunk_v2.patch
Thanks for catching that Stack. Missed while creating the patch.
> Allow filter to be specified for Get from HBase shell
> -----------------------------------------------------
>
> Key: HBASE-7089
> URL: https://issues.apache.org/jira/browse/HBASE-7089
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 0.96.0
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7089_trunk.patch, HBASE-7089_trunk_v2.patch
>
>
> Unlike scan, get in HBase shell does not accept FILTER as an argument.
> {noformat}
> hbase(main):001:0> get 'table', 'row3', {FILTER => "ValueFilter (=, 'binary:valueX')"}
> COLUMN CELL
> ERROR: Failed parse of {"FILTER"=>"ValueFilter (=, 'binary:valueX')"}, Hash
> Here is some help for this command:
> ...
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira