[GitHub] john-bodley commented on a change in pull request #6015: Allow customizable cursor init params

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #6015: Allow customizable cursor init params
URL: https://github.com/apache/incubator-superset/pull/6015#discussion_r222505212
 
 

 ##########
 File path: superset/models/core.py
 ##########
 @@ -767,6 +767,20 @@ def get_sqla_engine(self, schema=None, nullpool=True, user_name=None):
         if DB_CONNECTION_MUTATOR:
             url, params = DB_CONNECTION_MUTATOR(
                 url, params, effective_username, security_manager)
+
+        custom_url_params = None
 
 Review comment:
   Can't this all be handled in the `DB_CONNECTION_MUTATOR`? Currently it feels like you're trying to solve an Airbnb specific problem. In you custom mutator you could probably use [inspect](https://stackoverflow.com/questions/2654113/how-to-get-the-callers-method-name-in-the-called-method) to determine the context in which engine was instantiated. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org