You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/05/11 11:42:16 UTC
[GitHub] [calcite] xy2953396112 opened a new pull request #1972: [CALCITE-3988] Intersect in RelMdRowCount doesn't take into account '…
xy2953396112 opened a new pull request #1972:
URL: https://github.com/apache/calcite/pull/1972
…intersect all'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on a change in pull request #1972: [CALCITE-3988] Intersect in RelMdRowCount doesn't take into account '…
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on a change in pull request #1972:
URL: https://github.com/apache/calcite/pull/1972#discussion_r425749953
##########
File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdRowCount.java
##########
@@ -108,7 +108,11 @@ public Double getRowCount(Intersect rel, RelMetadataQuery mq) {
rowCount = partialRowCount;
}
}
- return rowCount;
+ if (!rel.all) {
+ return rowCount;
+ } else {
+ return rowCount * 2;
Review comment:
@chunwei Is there any problems here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hsyuan closed pull request #1972: [CALCITE-3988] Intersect in RelMdRowCount doesn't take into account '…
Posted by GitBox <gi...@apache.org>.
hsyuan closed pull request #1972:
URL: https://github.com/apache/calcite/pull/1972
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org