You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/14 09:31:09 UTC
[GitHub] [flink] vthinkxie opened a new pull request #11731:
[FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
vthinkxie opened a new pull request #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731
## What is the purpose of the change
ref https://issues.apache.org/jira/browse/FLINK-17130
## Brief change log
add JM log list
add JM log detail
## Verifying this change
- the job manager log list
- the job manager log detail
- check the download button
- check the reload button
- check the fullscreen button
before:
after:
list:
log-detail from the list:
full screen:
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11731: [FLINK-17130][web]
Enable listing JM Logs and displaying Logs by filename
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731#issuecomment-613339867
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a68b809cce8c2bce5d127b9e4b95a7a01e42466f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11731:
[FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731#issuecomment-613339867
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160182651",
"triggerID" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"triggerType" : "PUSH"
}, {
"hash" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7451",
"triggerID" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a68b809cce8c2bce5d127b9e4b95a7a01e42466f Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160182651) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7451)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on issue #11731: [FLINK-17130][web]
Enable listing JM Logs and displaying Logs by filename
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on issue #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731#issuecomment-613338067
@simplejason do you have time to take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11731:
[FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731#issuecomment-613339867
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160182651",
"triggerID" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"triggerType" : "PUSH"
}, {
"hash" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7451",
"triggerID" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a68b809cce8c2bce5d127b9e4b95a7a01e42466f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160182651) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7451)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11731: [FLINK-17130][web]
Enable listing JM Logs and displaying Logs by filename
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731#issuecomment-613333795
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2a9f46b4685be6f9fcd753039a40f58467df5c98 (Tue Apr 14 09:34:38 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17130).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] simplejason commented on a change in pull request #11731:
[FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
Posted by GitBox <gi...@apache.org>.
simplejason commented on a change in pull request #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731#discussion_r408120348
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job-manager/log-detail/job-manager-log-detail.component.html
##########
@@ -16,5 +16,21 @@
~ limitations under the License.
-->
+<div class="breadcrumb">
+ <nz-breadcrumb>
+ <nz-breadcrumb-item>
+ <a [routerLink]="['../']"><i nz-icon type="rollback" theme="outline"></i> Log List</a>
+ </nz-breadcrumb-item>
+ <nz-breadcrumb-item>
+ {{ logName }}
+ </nz-breadcrumb-item>
+ </nz-breadcrumb>
+ <flink-refresh-download
+ [isLoading]="isLoading"
+ [downloadHref]="downloadUrl"
+ [downloadName]="logName"
+ (reload)="reload()"
+ (fullScreen)="toggleFullScreen($event)">
+ </flink-refresh-download>
+</div>
<flink-monaco-editor [value]="logs"></flink-monaco-editor>
Review comment:
When I scroll the log content, a border appears at the top of the editor, I think it would be nice to hide it, but it's also ok if we want to keep it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] simplejason commented on a change in pull request #11731:
[FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
Posted by GitBox <gi...@apache.org>.
simplejason commented on a change in pull request #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731#discussion_r408116399
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job-manager/log-detail/job-manager-log-detail.component.less
##########
@@ -16,11 +16,40 @@
* limitations under the License.
*/
+@import "theme";
+
+:host {
+ display: block;
+ height: 100%;
+ &.full-screen {
+ position: fixed;
+ top: 0;
+ bottom: 0;
+ right: 0;
+ left: 0;
+ background: @component-background;
+ z-index: 99;
+ flink-monaco-editor {
+ height: calc(~"100vh - 65px");
+ }
+ }
+}
+
flink-monaco-editor {
- height: calc(~"100vh - 160px");
+ height: calc(~"100vh - 220px");
}
-:host {
+.breadcrumb {
+ background: @component-background;
+ border-bottom: 1px solid @border-color-split;
+ margin-bottom: 16px;
+ padding: 12px 24px;
position: relative;
- display: block;
+}
+
+flink-refresh-download {
+ position: absolute;
+ right: 12px;
+ top: 0;
+ line-height: 47px;
Review comment:
We seem to have done some duplicate work with `Task Managers` log list, can we make these codes reusable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11731:
[FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731#issuecomment-613339867
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160182651",
"triggerID" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"triggerType" : "PUSH"
}, {
"hash" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7451",
"triggerID" : "a68b809cce8c2bce5d127b9e4b95a7a01e42466f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a68b809cce8c2bce5d127b9e4b95a7a01e42466f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160182651) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7451)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services