You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:01:31 UTC
[GitHub] [flink] zoudan commented on a change in pull request #12542: [FLINK-18168][table-runtime-blink] return a copy of reuseArray in ObjectArrayConverter.toBinaryArray()
zoudan commented on a change in pull request #12542:
URL: https://github.com/apache/flink/pull/12542#discussion_r437335435
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/util/DataFormatConverters.java
##########
@@ -1138,7 +1138,7 @@ private ArrayData toBinaryArray(T[] value) {
}
}
reuseWriter.complete();
- return reuseArray;
+ return reuseArray.copy();
Review comment:
thanks for reminding
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/util/DataFormatConverters.java
##########
@@ -1138,7 +1138,7 @@ private ArrayData toBinaryArray(T[] value) {
}
}
reuseWriter.complete();
- return reuseArray;
+ return reuseArray.copy();
Review comment:
OK，I will add a test for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org