[GitHub] [tvm] joshherr-quic commented on pull request #9674: Pass bisection tool using pass_instrument infrastructure

[GitBox <gi...@apache.org>]

joshherr-quic commented on pull request #9674:
URL: https://github.com/apache/tvm/pull/9674#issuecomment-989125714


   > Personally I've found just letting compilation run and looking at the debug dump (eg using TVM_LOG_DEBUG="DEFAULT=1") is enough to help me find where things have gone off the rails. However I can see having a hard stop would also be valuable.
   > 
   > The required vs optional distinction is probably going to be fragile, especially since passes often build on each other. But tackling that issue is a design problem on its own (eg can me label passes with 'requires' and have a pass list validation or completion step to 'resolve interpass dependencies'). Would you consider dumbing down this instrument to simply count passes and not try to take on the opt vs req distinction?
   > 
   > Thanks!
   
   That fragility is something I was worried about as well. I think it makes sense to tackle that in a separate PR. I'll go ahead and limit this code to just printing debug info.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org