You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by pavelsmajda <gi...@git.apache.org> on 2018/12/27 12:35:08 UTC
[GitHub] tomee pull request #316: Interceptor titles
GitHub user pavelsmajda opened a pull request:
https://github.com/apache/tomee/pull/316
Interceptor titles
It seems that title was ignored when there is another title under the top section. I removed so it should be displaying titles correctly now.
Issue https://issues.apache.org/jira/browse/TOMEE-2411
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pavelsmajda/tomee cdiinterceptorname
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomee/pull/316.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #316
----
commit b0aa65079ce4be118c4aea9b12d2e1921132fcbe
Author: pavelsmajda <pa...@...>
Date: 2018-12-27T12:33:25Z
It seems that title was ignored when there is another title under the top section. I removed so it should be displaying titles correctly.
Issue https://issues.apache.org/jira/browse/TOMEE-2411
----
---
[GitHub] tomee issue #316: Interceptor titles
Posted by pavelsmajda <gi...@git.apache.org>.
Github user pavelsmajda commented on the issue:
https://github.com/apache/tomee/pull/316
@josehenriqueventura
Thanks a lot Jose for your detailed tutorial.
I followed steps you provided, but document was generated correctly for me. I also compared those 2 docs and they're completely identical. I'm not sure what we can do with it now. Any thoughts why it's displaying "null" as a header?
Also I saw a task and email thread about migration to adoc format, should I migrate docs do .adoc instead of .MD files?
Thank you very much for your help.
---
[GitHub] tomee issue #316: Interceptor titles
Posted by josehenriqueventura <gi...@git.apache.org>.
Github user josehenriqueventura commented on the issue:
https://github.com/apache/tomee/pull/316
Thank you for your PR.
I tried to generate the .html file based on those two .md files that you modified, but they were generated with the title after the following commit: https://github.com/apache/tomee/commit/0efe6d0b9ca044d2be312f7baa4b0918a059ee6c
The **tomee-site-generator** searches for the String "title:" instead of "#...".
https://github.com/apache/tomee-site-generator/blob/ee0724fcdf3543b014a3869ebbd22512159499ba/src/main/java/org/apache/tomee/website/JbakeHeaders.java#L118
If you haven't yet, you might try to checkout tomee-site-generator project and try out adding the title to file and see the results.
Checkout https://github.com/apache/tomee-site-generator/
- mvn clean compile
- tomee-site-generator/target/site-1.0-SNAPSHOT/tomee-8.0/examples/cdi-alternative-and-stereotypes.html (double click and the title is NULL)
- then you can modify this file **/tomee-site-generator/repos/tomee-8.0/examples/cdi-alternative-and-stereotypes/README.md**, just adding the title as was added in this commit https://github.com/apache/tomee/commit/0efe6d0b9ca044d2be312f7baa4b0918a059ee6c;
- compile the project again
- **tomee-site-generator/target/site-1.0-SNAPSHOT/tomee-8.0/examples/cdi-alternative-and-stereotypes.html** (double click and the title should be displayed).
I hope I have helped. =)
---
Re: [GitHub] tomee issue #316: Interceptor titles
Posted by Pavel Šmajda <pa...@gmail.com>.
ohh got it now :))) In this case, yes, issue is fixed. Thanks for help.
I'll close the issue.
On Thu, Dec 27, 2018 at 4:13 PM josehenriqueventura <gi...@git.apache.org>
wrote:
> Github user josehenriqueventura commented on the issue:
>
> https://github.com/apache/tomee/pull/316
>
> @pavelsmajda
> They were generated correctly now because that commit was merged into
> the master branch and then you cloned the **tomee-site-generator**, it
> checks out the latest revision of the repository, and the last one already
> contains that fix.
>
> If you removed the "title:.." from the README.md file, you probably
> will get that NULL and
> I got that error here because I had a cached version of master repo
> which didn't have that fix. =)
>
> So.. I think this issue is already fixed.
>
> > Also, I saw a task and email thread about migration to adoc format,
> should I migrate docs do .adoc instead of .MD files?
> I'm not sure how the guys are processing with these changes. I would
> say that would be good to ask it in the dev list. =)
>
>
>
> ---
>
--
Tel.:+420 777 309 176
[GitHub] tomee issue #316: Interceptor titles
Posted by josehenriqueventura <gi...@git.apache.org>.
Github user josehenriqueventura commented on the issue:
https://github.com/apache/tomee/pull/316
@pavelsmajda
They were generated correctly now because that commit was merged into the master branch and then you cloned the **tomee-site-generator**, it checks out the latest revision of the repository, and the last one already contains that fix.
If you removed the "title:.." from the README.md file, you probably will get that NULL and
I got that error here because I had a cached version of master repo which didn't have that fix. =)
So.. I think this issue is already fixed.
> Also, I saw a task and email thread about migration to adoc format, should I migrate docs do .adoc instead of .MD files?
I'm not sure how the guys are processing with these changes. I would say that would be good to ask it in the dev list. =)
---