[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one

[GitBox <gi...@apache.org>]

cxzl25 commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r894606889


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -75,6 +64,13 @@ class SparkTBinaryFrontendService(
       val respConfiguration = new java.util.HashMap[String, String]()
       respConfiguration.put("kyuubi.engine.id", sc.applicationId)
 
+      if (req.getConfiguration != null) {

Review Comment:
   Now the token is updated using serialized credentials in `openSession`, but the initial engine initialization sql (`kyuubi.engine.initialize.sql`) may fail to execute. 
   For example, in master local mode, the engine does not have a Hive delegation token.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org