You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/28 13:18:12 UTC

[GitHub] [flink] twalthr commented on a change in pull request #14790: [FLINK-21134] Introduce 'execution-mode' config option

twalthr commented on a change in pull request #14790:
URL: https://github.com/apache/flink/pull/14790#discussion_r566085878



##########
File path: flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -358,6 +359,18 @@
                                     .list(text("'ng': new generation scheduler"))
                                     .build());
 
+    @Documentation.Section(Documentation.Sections.EXPERT_SCHEDULING)
+    public static final ConfigOption<SchedulerExecutionMode> SCHEDULER_EXECUTION_MODE =
+            key("execution-mode")

Review comment:
       Isn't this option a bit misleading with our batch/streaming execution mode? 
   
   https://ci.apache.org/projects/flink/flink-docs-release-1.12/concepts/glossary.html#runtime-execution-mode
   
   Wouldn't `scheduler-mode` be more specific to avoid confusion?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org