You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "aggarwal-h (via GitHub)" <gi...@apache.org> on 2023/06/17 17:01:35 UTC

[GitHub] [echarts] aggarwal-h opened a new pull request, #18778: feat(axisPointer): trigger axisPointer when data is null (with echarts.connect)

aggarwal-h opened a new pull request, #18778:
URL: https://github.com/apache/echarts/pull/18778

   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   This PR adds a `triggerOnNull` option to the axisPointer that enables the triggering of the axisPointer on `null` values when using the `echarts.connect` or `dispatchAction` API.
   
   
   ### Fixed issues
   
   None.
   
   
   ## Details
   
   ### Before: What was the problem?
   
   Prior to this PR, when connecting multiple charts using `echarts.connect` with trigger set to `axis`, the axisPointer would not get triggered if the value in the connected chart was `null`. 
   
   An example of this can be seen in the image below (https://codesandbox.io/s/echarts-without-toggleonnull-fy4g4d?file=/src/index.js): 
   <img width="646" alt="SCR-20230617-lhpv" src="https://github.com/apache/echarts/assets/77129877/1027f180-285b-4514-8fbe-14b50f3e6d9d">
   
   
   
   
   ### After: How does it behave after the fixing?
   
   After this PR, the user can set the option to trigger the axisPointer on `null` using the `triggerOnNull` option, like below:
   ```js
   axisPointer: {
       triggerOnNull: true
   }
   ```
   
   _Note_: axisPointer's `snap` property should be disabled in the `xAxis` to see this work.
   
   <img width="1372" alt="SCR-20230617-lovx" src="https://github.com/apache/echarts/assets/77129877/9e2168d1-d7e7-4f1f-a896-a06983395e5c">
   
   
   
   
   ## Document Info
   
   One of the following should be checked.
   
   - [ ] This PR doesn't relate to document changes
   - [x] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   N.A.
   
   
   
   ## Others
   
   ### Merging options
   
   - [x] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #18778: feat(axisPointer): trigger axisPointer when data is null (with echarts.connect)

Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18778:
URL: https://github.com/apache/echarts/pull/18778#issuecomment-1595807250

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] aggarwal-h commented on pull request #18778: feat(axisPointer): trigger axisPointer when data is null (with echarts.connect)

Posted by "aggarwal-h (via GitHub)" <gi...@apache.org>.
aggarwal-h commented on PR #18778:
URL: https://github.com/apache/echarts/pull/18778#issuecomment-1599739502

   Thanks for your feedback @Ovilia! I have added some test cases. Please let me know if anything else is required 🙂.
   
   <img width="1657" alt="Screenshot 2023-06-20 at 7 24 22 PM" src="https://github.com/apache/echarts/assets/77129877/93ed7a76-ea92-4c0f-85f4-aead77d0b627">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org