You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "OmBiradar (via GitHub)" <gi...@apache.org> on 2026/07/01 18:00:36 UTC
[PR] GH-50087: [DOCS] [MINOR]Fix the docs of `arrow::MemoryManager` [arrow]
OmBiradar opened a new pull request, #50324:
URL: https://github.com/apache/arrow/pull/50324
* Removes a duplicate line
* Minor grammar fix
### Rationale for this change
I believe the statement
> The associated class :class:`arrow::MemoryManager` specifies how to allocate on a given device.
was repeated twice and there was some grammatical mistake in the same paragraph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50087: [Docs][C++] [Docs][C++] Fix sentence structure in `memory.rst` regarding `MemoryManager` [arrow]
Posted by "OmBiradar (via GitHub)" <gi...@apache.org>.
OmBiradar commented on PR #50324:
URL: https://github.com/apache/arrow/pull/50324#issuecomment-4861883128
Hey @amoeba I have changed the titles of both the PR and the Issue. Let me know if its ok.
I will keep in mind the points you mentioned in all my future PR's and issues raised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50087: [Docs][C++] Fix the docs of `arrow::MemoryManager` [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #50324:
URL: https://github.com/apache/arrow/pull/50324#issuecomment-4859331266
Hey @OmBiradar, thanks for the PR. The patch looks good.
Before we approve and merge, could you make some changes to the issue title and PR title to help maintainers and future contributors out?
- I already changed the PR title a bit:
- I changed [DOCS] to [Docs] just to match the style used in other PRs. Using existing issues and PRs as a guide for new ones is often a good idea.
- I removed the [MINOR] tag since we don't use that tag when the PR has an associated issue. Filing an issue like you did is always a good step if you aren't sure but, now that you have some more experience, changes like this are fine as minor PRs and filing an issue first isn't required.
- I added [C++] since it helps to clarify this Docs change is to the C++ docs.
- Can you improve the wording of the PR title? "Fix the docs of arrow::MemoryManager" isn't specific enough. PR titles will show up in the git blame so something specific would be better. For example, "Remove misplaced sentence fragment in memory.rst"
- Can you improve the issue title? Something more specific (like above) would be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50087: [Docs][C++] Fix sentence structure in memory.rst regarding `MemoryManager` [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #50324:
URL: https://github.com/apache/arrow/pull/50324#issuecomment-4879274478
Thanks @OmBiradar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50087: [Docs][C++] Fix sentence structure in memory.rst regarding `MemoryManager` [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba merged PR #50324:
URL: https://github.com/apache/arrow/pull/50324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50087: [Docs][C++] Fix sentence structure in memory.rst regarding `MemoryManager` [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50324:
URL: https://github.com/apache/arrow/pull/50324#issuecomment-4882255227
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 43e2bbe541b31f27722ef15f38922f0ad7810474.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/85137572440) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50087: [DOCS] [MINOR]Fix the docs of `arrow::MemoryManager` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50324:
URL: https://github.com/apache/arrow/pull/50324#issuecomment-4858708398
:warning: GitHub issue #50087 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50087: [DOCS] [MINOR]Fix the docs of `arrow::MemoryManager` [arrow]
Posted by "OmBiradar (via GitHub)" <gi...@apache.org>.
OmBiradar commented on PR #50324:
URL: https://github.com/apache/arrow/pull/50324#issuecomment-4858717392
@amoeba
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org