You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/09 10:23:14 UTC
[GitHub] [airflow] ashb commented on a change in pull request #5065:
[AIRFLOW-4261] Minor refactoring on jobs.py
ashb commented on a change in pull request #5065: [AIRFLOW-4261] Minor refactoring on jobs.py
URL: https://github.com/apache/airflow/pull/5065#discussion_r273423605
##########
File path: airflow/jobs.py
##########
@@ -665,8 +665,7 @@ def manage_slas(self, dag, session=None):
slas = (
session
.query(SlaMiss)
- .filter(SlaMiss.notification_sent == False) # noqa: E712
- .filter(SlaMiss.dag_id == dag.dag_id)
+ .filter(SlaMiss.notification_sent == False, SlaMiss.dag_id == dag.dag_id) # noqa: E712
Review comment:
Oh wow that's mental. I would not have expected that much of a difference! What DB did you test on btw?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services