You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Maria Odea Ching (JIRA)" <ji...@codehaus.org> on 2006/05/19 08:58:41 UTC

[jira] Closed: (MJAVADOC-56) excludePackageNames should accept wildars

     [ http://jira.codehaus.org/browse/MJAVADOC-56?page=all ]
     
Maria Odea Ching closed MJAVADOC-56:
------------------------------------

    Resolution: Fixed

> excludePackageNames should accept wildars
> -----------------------------------------
>
>          Key: MJAVADOC-56
>          URL: http://jira.codehaus.org/browse/MJAVADOC-56
>      Project: Maven 2.x Javadoc Plugin
>         Type: Improvement

>     Reporter: Michael Böckling
>     Assignee: Maria Odea Ching
>     Priority: Minor
>      Fix For: 2.0
>  Attachments: MJAVADOC-56-maven-javadoc-plugin.patch
>
> Original Estimate: 6 hours
>        Time Spent: 5 hours, 30 minutes
>         Remaining: 30 minutes
>
> We want o exclude *.internal* packages from Javadoc generation, but the current implementation only permits fully qualified package names. An ANT style exclude pattern would be nice, but I gues that depends on FileUtils.getFilesFromExtension() supporting an exclusions argument? Never understood anyway why (the imho pretty nice) ANT DirectoryScanner is not used, and plextools reinvent the wheel...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Closed: (MJAVADOC-56) excludePackageNames should accept wildars

Posted by Brett Porter <br...@apache.org>.
Ok, it should probably be a new issue in future. Thanks for the details.

- Brett

Maria Odea Ching wrote:
> 
> When it was previously closed, the excludePackageNames already accepts 
> wild cards.
> 
> Sample structure:
> +--org.apache.maven
>    +--sample
>        +--subpackageToBeExcluded
>          --ClassThatShouldNotBeExcluded.java     +--sample2
> 
> pom.xml plugin configuration:
> <configuration>
>  
> <excludePackageNames>*.sample2:org.apache.maven.sample.*</excludePackageNames> 
> 
> </configuration>
> 
> With the above configuration, org.apache.maven.sample2 and 
> org.apache.maven.sample.packageToBeExcluded packages are excluded.
> The problem was ClassThatShouldNotBeExcluded.java is also being excluded 
> while that should not be the case. I think I overlooked this when I
> previously resolved the issue and just found out about it. I'm so sorry 
> about that..
> 
> 
> Brett Porter wrote:
>> Why was this closed with a fix for in the past?
>>
>> Maria Odea Ching (JIRA) wrote:
>>>      [ http://jira.codehaus.org/browse/MJAVADOC-56?page=all ]
>>>      Maria Odea Ching closed MJAVADOC-56:
>>> ------------------------------------
>>>
>>>     Resolution: Fixed
>>>
>>>> excludePackageNames should accept wildars
>>>> -----------------------------------------
>>>>
>>>>          Key: MJAVADOC-56
>>>>          URL: http://jira.codehaus.org/browse/MJAVADOC-56
>>>>      Project: Maven 2.x Javadoc Plugin
>>>>         Type: Improvement
>>>
>>>>     Reporter: Michael Böckling
>>>>     Assignee: Maria Odea Ching
>>>>     Priority: Minor
>>>>      Fix For: 2.0
>>>>  Attachments: MJAVADOC-56-maven-javadoc-plugin.patch
>>>>
>>>> Original Estimate: 6 hours
>>>>        Time Spent: 5 hours, 30 minutes
>>>>         Remaining: 30 minutes
>>>>
>>>> We want o exclude *.internal* packages from Javadoc generation, but 
>>>> the current implementation only permits fully qualified package 
>>>> names. An ANT style exclude pattern would be nice, but I gues that 
>>>> depends on FileUtils.getFilesFromExtension() supporting an 
>>>> exclusions argument? Never understood anyway why (the imho pretty 
>>>> nice) ANT DirectoryScanner is not used, and plextools reinvent the 
>>>> wheel...
>>>
>>
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 


-- 
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [jira] Closed: (MJAVADOC-56) excludePackageNames should accept wildars

Posted by Maria Odea Ching <oc...@exist.com>.
When it was previously closed, the excludePackageNames already accepts 
wild cards.

Sample structure:
+--org.apache.maven
    +--sample
        +--subpackageToBeExcluded
          --ClassThatShouldNotBeExcluded.java  
    +--sample2

pom.xml plugin configuration:
<configuration>
  
<excludePackageNames>*.sample2:org.apache.maven.sample.*</excludePackageNames>
</configuration>

With the above configuration, org.apache.maven.sample2 and 
org.apache.maven.sample.packageToBeExcluded packages are excluded.
The problem was ClassThatShouldNotBeExcluded.java is also being excluded 
while that should not be the case. I think I overlooked this when I
previously resolved the issue and just found out about it. I'm so sorry 
about that..


Brett Porter wrote:
> Why was this closed with a fix for in the past?
>
> Maria Odea Ching (JIRA) wrote:
>>      [ http://jira.codehaus.org/browse/MJAVADOC-56?page=all ]
>>      Maria Odea Ching closed MJAVADOC-56:
>> ------------------------------------
>>
>>     Resolution: Fixed
>>
>>> excludePackageNames should accept wildars
>>> -----------------------------------------
>>>
>>>          Key: MJAVADOC-56
>>>          URL: http://jira.codehaus.org/browse/MJAVADOC-56
>>>      Project: Maven 2.x Javadoc Plugin
>>>         Type: Improvement
>>
>>>     Reporter: Michael Böckling
>>>     Assignee: Maria Odea Ching
>>>     Priority: Minor
>>>      Fix For: 2.0
>>>  Attachments: MJAVADOC-56-maven-javadoc-plugin.patch
>>>
>>> Original Estimate: 6 hours
>>>        Time Spent: 5 hours, 30 minutes
>>>         Remaining: 30 minutes
>>>
>>> We want o exclude *.internal* packages from Javadoc generation, but 
>>> the current implementation only permits fully qualified package 
>>> names. An ANT style exclude pattern would be nice, but I gues that 
>>> depends on FileUtils.getFilesFromExtension() supporting an 
>>> exclusions argument? Never understood anyway why (the imho pretty 
>>> nice) ANT DirectoryScanner is not used, and plextools reinvent the 
>>> wheel...
>>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [jira] Closed: (MJAVADOC-56) excludePackageNames should accept wildars

Posted by Brett Porter <br...@apache.org>.
Why was this closed with a fix for in the past?

Maria Odea Ching (JIRA) wrote:
>      [ http://jira.codehaus.org/browse/MJAVADOC-56?page=all ]
>      
> Maria Odea Ching closed MJAVADOC-56:
> ------------------------------------
> 
>     Resolution: Fixed
> 
>> excludePackageNames should accept wildars
>> -----------------------------------------
>>
>>          Key: MJAVADOC-56
>>          URL: http://jira.codehaus.org/browse/MJAVADOC-56
>>      Project: Maven 2.x Javadoc Plugin
>>         Type: Improvement
> 
>>     Reporter: Michael Böckling
>>     Assignee: Maria Odea Ching
>>     Priority: Minor
>>      Fix For: 2.0
>>  Attachments: MJAVADOC-56-maven-javadoc-plugin.patch
>>
>> Original Estimate: 6 hours
>>        Time Spent: 5 hours, 30 minutes
>>         Remaining: 30 minutes
>>
>> We want o exclude *.internal* packages from Javadoc generation, but the current implementation only permits fully qualified package names. An ANT style exclude pattern would be nice, but I gues that depends on FileUtils.getFilesFromExtension() supporting an exclusions argument? Never understood anyway why (the imho pretty nice) ANT DirectoryScanner is not used, and plextools reinvent the wheel...
> 


-- 
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org