You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/06/21 19:06:00 UTC

[jira] [Work logged] (KNOX-1881) DefaultKeystoreService should use Java NIO API locking as well

     [ https://issues.apache.org/jira/browse/KNOX-1881?focusedWorklogId=264897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264897 ]

ASF GitHub Bot logged work on KNOX-1881:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Jun/19 19:05
            Start Date: 21/Jun/19 19:05
    Worklog Time Spent: 10m 
      Work Description: asfgit commented on pull request #104: KNOX-1881 - DefaultKeystoreService should use Java NIO API locking as well
URL: https://github.com/apache/knox/pull/104
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 264897)
            Time Spent: 10m
    Remaining Estimate: 0h

> DefaultKeystoreService should use Java NIO API locking as well
> --------------------------------------------------------------
>
>                 Key: KNOX-1881
>                 URL: https://issues.apache.org/jira/browse/KNOX-1881
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: KnoxCLI, Server
>            Reporter: Robert Levas
>            Assignee: Kevin Risden
>            Priority: Critical
>             Fix For: 1.3.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The file locking mechanism in {{org.apache.knox.gateway.services.security.impl.DefaultKeystoreService}} today relies on read/write locks to prevent multiple threads from editing a single keystore. Java NIO API file locking adds the protection for reading/writing from multiple JVMs. Since DefaultKeystoreService is used in both gateway and knoxcli, we need to protect against this type of access happening at once.
> https://docs.oracle.com/javase/8/docs/api/java/nio/channels/FileLock.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)