You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Eriks Dobelis (JIRA)" <ji...@apache.org> on 2006/10/25 11:57:16 UTC
[jira] Created: (OFBIZ-405) Showing invoice total with and without
tax
Showing invoice total with and without tax
------------------------------------------
Key: OFBIZ-405
URL: http://issues.apache.org/jira/browse/OFBIZ-405
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: accounting
Reporter: Eriks Dobelis
Priority: Minor
This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
>From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Eriks Dobelis (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12448988 ]
Eriks Dobelis commented on OFBIZ-405:
-------------------------------------
Seems that Si is not going to look at this or OFBIZ-366 patch. Maybe, Jacques, you could commit it?
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Eriks Dobelis (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12458776 ]
Eriks Dobelis commented on OFBIZ-405:
-------------------------------------
Sorry for typos. End of the year - too much work :)
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff, invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Eriks Dobelis (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12444628 ]
Eriks Dobelis commented on OFBIZ-405:
-------------------------------------
FO file may need some small changes in sizes of columns, etc., but I have not included that in the diff because it is unclear whether this addition will be commented out or no.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12460311 ]
Si Chen commented on OFBIZ-405:
-------------------------------
This patch looks OK, except for a couple of modifications which we'll make for you:
1. You should use the pre-defined ZERO instead of your own BigDecimal("0")
2. When using BigDecimal during additions, do not round down to decimals immediately. Round down to decimals+1 during intermediate looping and then round down to decimals after you are done. This means that:
invoiceTaxTotal = invoiceTaxTotal.add( amount.multiply(quantity)).setScale(decimals,rounding);
should be:
invoiceTaxTotal = invoiceTaxTotal.add( amount.multiply(quantity)).setScale(decimals+1, rounding);
Then you should have a
invoiceTaxTotal = invoiceTaxTotal.setScale(decimals, rounding)
Otherwise, you will have a problem where these two values
1.08423465
1.08358239
would be rounded to 1.08 and 1.08 and added to 1.16 instead of being rounded to 1.084 and 1.083 and added to 1.17.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449250 ]
Jacopo Cappellato commented on OFBIZ-405:
-----------------------------------------
I too would be in favor of adding the "total excluding tax" just before the grand total.
However, before we commit it, I think that we should wait for Si's feedback, even if this could delay the resolution of this patch: there's no hurry because in the meantime, the persons that need this patch, can easily apply it to their local environments.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12446546 ]
Jacopo Cappellato commented on OFBIZ-405:
-----------------------------------------
I've not reviewed the patch, but for me it would be ok to display the total without tax in the invoice.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Eriks Dobelis (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12460962 ]
Eriks Dobelis commented on OFBIZ-405:
-------------------------------------
Thanks Si and Leon for improvements!
I checked only INV_SALES_TAX, because this was initial purpose. I agree that static list is not the best way, but I don't think that including extra column is worth the overhead it creates. May be we should make this list configurable using an entry in property file?
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax-2.diff, invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12455241 ]
Jacopo Cappellato commented on OFBIZ-405:
-----------------------------------------
WARNING:
the fo.ftl code in the patch will break the invoice PDF (now that we have moved to the new FOP version); in fact, each table-row element must contain at least one table-cell element, and each table-cell element must contain at least one block element.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449141 ]
Jacques Le Roux commented on OFBIZ-405:
---------------------------------------
Well tried, spaces removed :'(
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "David Garrett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449296 ]
David Garrett commented on OFBIZ-405:
-------------------------------------
obvious typo ... I believe these labels should differ depending on the TaxAuthority.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-405) Showing invoice total with and without
tax
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=all ]
Jacques Le Roux reassigned OFBIZ-405:
-------------------------------------
Assignee: Jacques Le Roux
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Jacques Le Roux
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-405) Showing invoice total with and without
tax
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=all ]
Jacques Le Roux updated OFBIZ-405:
----------------------------------
Attachment: (was: invoicenotax.diff)
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449246 ]
Jacques Le Roux commented on OFBIZ-405:
---------------------------------------
Thanks Iain for your comment,
No more opinions ?
I think I will also put a vote for "Adding Tax ID in invoice header" (OFBIZ-362 currently commented out) because it seems that Si has not enough time to look at it.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449425 ]
Si Chen commented on OFBIZ-405:
-------------------------------
I will review this patch this week.
OFBIZ-366 is more complicated and should definitely be reviewed by David Jones and Jacopo before it's committed.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12445249 ]
Jacques Le Roux commented on OFBIZ-405:
---------------------------------------
I reviewed this patch and it sounds good to me. I will wait for Si looking at the previous issue and tell what he think before commiting this one.
Thanks Eriks
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Jacques Le Roux
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-405) Showing invoice total with and without
tax
Posted by "Eriks Dobelis (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=all ]
Eriks Dobelis updated OFBIZ-405:
--------------------------------
Attachment: invoicenotax.diff
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Iain Fogg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449222 ]
Iain Fogg commented on OFBIZ-405:
---------------------------------
My vote for the label would be "Total excluding tax" or "Total ex-tax"
I'd prefer to see the exTax total before the grand total.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Eriks Dobelis (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12458774 ]
Eriks Dobelis commented on OFBIZ-405:
-------------------------------------
I changed the interface according to Si's suggestion. Label is "Total excl. tax", which is more or less what Iain and Jacopo suggested. Also, FOP code know works on the current svn version.
Configurability of tax related labels based on TaxAuthority is beyond scope of this patch and if needed (I personally support it) should be created as a separate issue. This also would relate to more general question of configurability of invoices, etc.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff, invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "David Garrett (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449294 ]
David Garrett commented on OFBIZ-405:
-------------------------------------
I believe these labels should differ depenging on the TaxAuthority.
This would suggest an entity like TaxAuthorityContent with a taxAuthContentTypeId just like ProductContent might be a desirable place to store labels such as these.
In Australia the recommended Tax invoice formats are given in the PDF here ...
http://www.ato.gov.au/businesses/content.asp?doc=/content/48360.htm
It has 2 options for the labels:
when issued from a "cash register" ... Total Includes GST of $xx.xx
otherwise ... Total GST amount payable: $xx.xx
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449258 ]
Jacques Le Roux commented on OFBIZ-405:
---------------------------------------
Yes sure Jacopo.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-405) Showing invoice total with and without
tax
Posted by "Eriks Dobelis (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=all ]
Eriks Dobelis updated OFBIZ-405:
--------------------------------
Attachment: invoicenotax.diff
New version of the patch. Please, remove the previous version.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff, invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Eriks Dobelis (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449298 ]
Eriks Dobelis commented on OFBIZ-405:
-------------------------------------
I agree with David, that the right way would be to take names of the tax related items from some table with records for each Tax authority. VAT tax is probably called by different name in each country, and some countries will have specific additional requirements on naming of the field or maybe even layout. This is potentially new issue.
While we haven't implemented anything like TaxAuthorityContent or some interface to configure invoices I guess all suggested variations are fine, because I think that invoice form and the exact text and layout of items will be customized by each user. The important thing is to have the number itself available with some sample.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12458277 ]
Jacques Le Roux commented on OFBIZ-405:
---------------------------------------
Eriks,
If you have a chance to look at this issue. According to Jacopo it needs a new patch...
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Iain Fogg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449345 ]
Iain Fogg commented on OFBIZ-405:
---------------------------------
I also support David G's suggestion as a better overall solution. There seems to be a generalisation lurking in here somewhere...
. Being able to configure display of item level VAT/GST, item ex-tax unit price/cost, item subtotal
. Being able to configure order VAT/GST, and subtotal ex-tax
. Verbiage and layout of each of the above
Some common configurations used in Australia - David can probably be exhaustive...
Show item level tax-inclusive prices, order total, and total GST amount (see David's comment above)
Show item level GST and tax-inclusive price, order GST subtotal, and order total
Show item level GST, ex-tax price, and tax-inclusive price, order GST subtotal, and order total
There is no need to report the GST percentage because products are either GST-rateable (10%) or GST-free (0%). This is probably different for EU countries where the VAT is more complicated.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Eriks Dobelis (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12458391 ]
Eriks Dobelis commented on OFBIZ-405:
-------------------------------------
I am working on this know. I hope there will be a patch within few days or so.
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-405) Showing invoice total with and without
tax
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=all ]
Si Chen reassigned OFBIZ-405:
-----------------------------
Assignee: Si Chen (was: Jacques Le Roux)
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12449140 ]
Jacques Le Roux commented on OFBIZ-405:
---------------------------------------
I just wonder if everybody is ok with
1) description (total no tax)
2) location of the line (below grand total)
I'm sorry I can't attach a screen copy, it fails on my 2 Windows machines. The PDF looks like that
ItemNr Produit Description Qte Unit Price Montant
00001 this was e service for a product 20,00 $
00002 Big Gizmo w/ Legs 269,99 $
00003 sales tax 33,55 $
TOTAL 323,54 $
Total no tax 289,99 $
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461635 ]
Jacques Le Roux commented on OFBIZ-405:
---------------------------------------
I guess that entries in a properties file should be fine, but why are these types not defined in an enum in the DB BTW ?
Thanks
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax-2.diff, invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-405) Showing invoice total with and without
tax
Posted by "Leon Torres (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=all ]
Leon Torres updated OFBIZ-405:
------------------------------
Attachment: invoicenotax-2.diff
I tested the patch and found that it doesn't work at all. The problem is that the getInvoiceTaxTotal() method only checks for INV_SALES_TAX and ignores the other InvoiceItemTypes that are taxes. Hence, it returns the wrong results for purchase invoices, return invoices and even sales invoices.
I fixed it so it will include all tax types currently defined in InvoiceItemType. Here's a patch with my fixes and Si's recommended improvements. (invoicenotax-2.diff)
This version works ok, however it relies on a static List in InvoiceWorker to identify the tax types. Perhaps it would be better to include an extra column InvoiceItemType.isTax instead?
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax-2.diff, invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12458791 ]
Jacques Le Roux commented on OFBIZ-405:
---------------------------------------
Eriks,
Remove done, thanks for the patch. I agree with you for a new issue on "Configurability of tax related labels based on TaxAuthority "
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-405) Showing invoice total with and
without tax
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12450582 ]
Si Chen commented on OFBIZ-405:
-------------------------------
This looks like a good idea.
1. The InvoiceWorker method should be implemented as a new InvoiceWorker.getInvoiceTaxTotal() and an InvoiceWroker.getInvoiceNoTaxTotal(). The getInvoiceTaxTotal can be a simple getRelatedByAnd("InvoiceItem", UtilMisc.toMap("invoiceItemTypeId", "INV_SALES_TAX")) and getInvoiceNoTaxTotal can just subtract getInvoiceTaxTotal from getInvoiceTotalBd(). I think that is a cleaner implementation and a better way to structure the API methods.
2. What is the consensus here about what to put on the xsl:fo? Is what Eriks have here oK?
> Showing invoice total with and without tax
> ------------------------------------------
>
> Key: OFBIZ-405
> URL: http://issues.apache.org/jira/browse/OFBIZ-405
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: accounting
> Reporter: Eriks Dobelis
> Assigned To: Si Chen
> Priority: Minor
> Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using VAT. Of course this might be used by others too.
> Attached diff adds a line in the invoice showing total without tax (i.e. currently without amount of items of Invoice Sales Tax type) and the corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing Tax ID in the invoice), the invoice becomes usable in EU countries.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira