You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/01/07 12:49:01 UTC
[GitHub] [zeppelin] Reamer opened a new pull request #4014: [ZEPPELIN-5188] /note1 race condition CI
Reamer opened a new pull request #4014:
URL: https://github.com/apache/zeppelin/pull/4014
### What is this PR for?
This PR should fix a race condition between removing and saving notes in our CI setup
### What type of PR is it?
- Bug Fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5188
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #4014: [ZEPPELIN-5188] /note1 race condition CI
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4014:
URL: https://github.com/apache/zeppelin/pull/4014#discussion_r558828767
##########
File path: zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
##########
@@ -1685,7 +1685,7 @@ public void onOutputUpdated(String noteId, String paragraphId, int index,
try {
Note note = getNotebook().getNote(noteId);
if (note == null) {
- LOG.warn("Note " + noteId + " note found");
+ LOG.warn("Note {} note found", noteId);
Review comment:
-> not found
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4014: [ZEPPELIN-5188] /note1 race condition CI
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4014:
URL: https://github.com/apache/zeppelin/pull/4014#issuecomment-761530497
@Reamer In what kind of situation save will happen after removing ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4014: [ZEPPELIN-5188] /note1 race condition CI
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4014:
URL: https://github.com/apache/zeppelin/pull/4014#issuecomment-762113862
Thanks @Reamer LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4014: [ZEPPELIN-5188] /note1 race condition CI
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4014:
URL: https://github.com/apache/zeppelin/pull/4014#issuecomment-762340556
CI job that failed due to this race condition: https://github.com/apache/zeppelin/pull/3930/checks?check_run_id=1695607676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4014: [ZEPPELIN-5188] /note1 race condition CI
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4014:
URL: https://github.com/apache/zeppelin/pull/4014
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4014: [ZEPPELIN-5188] /note1 race condition CI
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4014:
URL: https://github.com/apache/zeppelin/pull/4014#issuecomment-762123094
I will merge this pull request into master and branch-0.9 on Wednesday (20.01.2021) if no further comments are received.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a change in pull request #4014: [ZEPPELIN-5188] /note1 race condition CI
Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #4014:
URL: https://github.com/apache/zeppelin/pull/4014#discussion_r559432841
##########
File path: zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
##########
@@ -1685,7 +1685,7 @@ public void onOutputUpdated(String noteId, String paragraphId, int index,
try {
Note note = getNotebook().getNote(noteId);
if (note == null) {
- LOG.warn("Note " + noteId + " note found");
+ LOG.warn("Note {} note found", noteId);
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4014: [ZEPPELIN-5188] /note1 race condition CI
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4014:
URL: https://github.com/apache/zeppelin/pull/4014#issuecomment-762084849
> @Reamer In what kind of situation save will happen after removing ?
I think this is a race condition during our integration tests. Checkout the JIRA ticket [ZEPPELIN-5188](https://issues.apache.org/jira/browse/ZEPPELIN-5188) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org