You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/09/29 07:16:48 UTC
[GitHub] [hadoop] riyakhdl opened a new pull request, #4951: YARN-6766 added helperMethod
riyakhdl opened a new pull request, #4951:
URL: https://github.com/apache/hadoop/pull/4951
JIRA: [YARN-6766] AppsBlock classes need a printOrNA() helper method
### Description of PR
The various *AppsBlock classes are riddled with statements like:
`.append(appInfo.getReservedVCores() == -1 ? "N/A" : String.valueOf(appInfo.getReservedVCores()))
`The code would be much cleaner if there were a utility method for that operation, e.g.:
`.append(printData(appInfo.getReservedCores()))
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4951: YARN-6766 added helperMethod
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #4951:
URL: https://github.com/apache/hadoop/pull/4951#issuecomment-1264539754
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | patch | 0m 37s | | https://github.com/apache/hadoop/pull/4951 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/4/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] riyakhdl closed pull request #4951: YARN-6766 added helperMethod
Posted by GitBox <gi...@apache.org>.
riyakhdl closed pull request #4951: YARN-6766 added helperMethod
URL: https://github.com/apache/hadoop/pull/4951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4951: YARN-6766 added helperMethod
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #4951:
URL: https://github.com/apache/hadoop/pull/4951#issuecomment-1261869492
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | patch | 0m 35s | | https://github.com/apache/hadoop/pull/4951 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/1/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4951: YARN-6766 added helperMethod
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #4951:
URL: https://github.com/apache/hadoop/pull/4951#issuecomment-1261903738
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | patch | 0m 40s | | https://github.com/apache/hadoop/pull/4951 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/3/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4951: YARN-6766 added helperMethod
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #4951:
URL: https://github.com/apache/hadoop/pull/4951#issuecomment-1263234976
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 43m 36s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 48s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 48s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 48s | | detect-secrets was not available. |
| +0 :ok: | checkmake | 0m 0s | | checkmake was not available. |
| +0 :ok: | shellcheck | 0m 0s | | Shellcheck was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +0 :ok: | buf | 0m 0s | | buf was not available. |
| +0 :ok: | buf | 0m 0s | | buf was not available. |
| -1 :x: | @author | 0m 0s | [/results-author.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/results-author.txt) | The patch appears to contain 85 @author tags which the community has agreed to not allow in code contributions. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 102 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 17m 29s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 27m 36s | | trunk passed |
| +1 :green_heart: | compile | 22m 7s | | trunk passed |
| +1 :green_heart: | checkstyle | 4m 48s | | trunk passed |
| +1 :green_heart: | mvnsite | 21m 4s | | trunk passed |
| +1 :green_heart: | javadoc | 9m 8s | | trunk passed |
| +1 :green_heart: | spotbugs | 36m 44s | | trunk passed |
| +1 :green_heart: | shadedclient | 53m 28s | | branch has no errors when building and testing our client artifacts. |
| -0 :warning: | patch | 53m 56s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 46s | [/patch-mvninstall-protobuf-2.5.0_java.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/patch-mvninstall-protobuf-2.5.0_java.txt) | java in the patch failed. |
| +1 :green_heart: | compile | 20m 37s | | the patch passed |
| +1 :green_heart: | cc | 20m 37s | | the patch passed |
| +1 :green_heart: | golang | 20m 37s | | the patch passed |
| +1 :green_heart: | javac | 20m 37s | | the patch passed |
| -1 :x: | blanks | 0m 1s | [/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/blanks-eol.txt) | The patch has 632 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | blanks | 0m 1s | [/blanks-tabs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/blanks-tabs.txt) | The patch 37791 line(s) with tabs. |
| -0 :warning: | checkstyle | 4m 33s | [/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/results-checkstyle-root.txt) | root: The patch generated 4 new + 8 unchanged - 0 fixed = 12 total (was 8) |
| +1 :green_heart: | mvnsite | 19m 33s | | the patch passed |
| -1 :x: | pylint | 28m 53s | [/patch-pylint-stderr.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/patch-pylint-stderr.txt) | Error running pylint. Please check pylint stderr files. |
| -1 :x: | pylint | 32m 36s | [/results-pylint.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/results-pylint.txt) | The patch generated 23921 new + 0 unchanged - 0 fixed = 23921 total (was 0) |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | javadoc | 7m 49s | | the patch passed |
| -1 :x: | spotbugs | 2m 11s | [/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html) | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| -1 :x: | spotbugs | 34m 48s | [/new-spotbugs-root.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/new-spotbugs-root.html) | root generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| -1 :x: | spotbugs | 0m 43s | [/patch-spotbugs-protobuf-2.5.0_java.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/patch-spotbugs-protobuf-2.5.0_java.txt) | java in the patch failed. |
| +1 :green_heart: | shadedclient | 53m 40s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 1064m 43s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| -1 :x: | asflicense | 2m 7s | [/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/results-asflicense.txt) | The patch generated 1331 ASF License warnings. |
| | | 1452m 23s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager |
| | Should org.apache.hadoop.yarn.server.resourcemanager.webapp.FairSchedulerAppsBlock$Helper be a _static_ inner class? At FairSchedulerAppsBlock.java:inner class? At FairSchedulerAppsBlock.java:[lines 131-138] |
| | Unread public/protected field:At FairSchedulerAppsBlock.java:[line 134] |
| SpotBugs | module:root |
| | Should org.apache.hadoop.yarn.server.resourcemanager.webapp.FairSchedulerAppsBlock$Helper be a _static_ inner class? At FairSchedulerAppsBlock.java:inner class? At FairSchedulerAppsBlock.java:[lines 131-138] |
| | Unread public/protected field:At FairSchedulerAppsBlock.java:[line 134] |
| Failed junit tests | hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy |
| | hadoop.crypto.TestCryptoCodec |
| | hadoop.crypto.TestCryptoStreamsWithOpensslSm4CtrCryptoCodec |
| | hadoop.service.launcher.TestServiceInterruptHandling |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/artifact/out/Dockerfile |
| Optional Tests | dupname asflicense codespell detsecrets compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle xmllint checkmake shellcheck shelldocs cc golang pylint buflint bufcompat |
| uname | Linux 97bf0ecf73c4 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / e22f5e75aeff23d6c8dc1b67cb6f4fd4a4c416dc |
| Default Java | Red Hat, Inc.-1.8.0_345-b01 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/testReport/ |
| Max. process+thread count | 3929 (vs. ulimit of 5500) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager . protobuf-2.5.0/java U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4951/2/console |
| versions | git=2.9.5 maven=3.6.3 spotbugs=4.2.2 pylint=2.6.0 xmllint=20901 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org