You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "blaginin (via GitHub)" <gi...@apache.org> on 2025/03/24 19:15:04 UTC
[I] Migrate `datafusion/sql` tests to `insta` [datafusion]
blaginin opened a new issue, #15397:
URL: https://github.com/apache/datafusion/issues/15397
In https://github.com/apache/datafusion/issues/15178, we're switching hard-coded constants in tests to `insta`.
This issue targets updating **sql tests** (`datafusion/sql`).
Examples of tests that need to be switched to `insta`:
- https://github.com/apache/datafusion/blob/45ed5aa5d008f7334bf64efc708038cd0c22059e/datafusion/sql/tests/sql_integration.rs#L95-L99
- https://github.com/apache/datafusion/blob/45ed5aa5d008f7334bf64efc708038cd0c22059e/datafusion/sql/tests/sql_integration.rs#L962-L966 (because of `quick_test`)
- https://github.com/apache/datafusion/blob/45ed5aa5d008f7334bf64efc708038cd0c22059e/datafusion/sql/tests/sql_integration.rs#L1353-L1356
Check [the original issue](https://github.com/apache/datafusion/issues/15178) for tips on how to do the switch and examples of completed PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate `datafusion/sql` tests to `insta` [datafusion]
Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on issue #15397:
URL: https://github.com/apache/datafusion/issues/15397#issuecomment-2749168478
This ticket is a bit more tricky than the others, because there are several places where direct swap to `assert_snapshot` won't work - I listed them above.
For `quick_test`, you may consider changing it to a function which just returns a logical plan rather than comparing it (in a way that's similar to `assert_physical_plan` → `batches_to_string` change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate `datafusion/sql` tests to `insta` [datafusion]
Posted by "qstommyshu (via GitHub)" <gi...@apache.org>.
qstommyshu commented on issue #15397:
URL: https://github.com/apache/datafusion/issues/15397#issuecomment-2753061213
I can give it a try!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate `datafusion/sql` tests to `insta` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #15397:
URL: https://github.com/apache/datafusion/issues/15397#issuecomment-2752420168
I think this is a good first issue as it is well explained and doesn't need deep DataFusion knowledge, so marking as such
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate `datafusion/sql` tests to `insta` [datafusion]
Posted by "qstommyshu (via GitHub)" <gi...@apache.org>.
qstommyshu commented on issue #15397:
URL: https://github.com/apache/datafusion/issues/15397#issuecomment-2753061284
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Migrate `datafusion/sql` tests to `insta` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #15397: Migrate `datafusion/sql` tests to `insta`
URL: https://github.com/apache/datafusion/issues/15397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org