[jira] [Commented] (SENTRY-1921) Make SentryServiceFactory.create static and all calling instances use the static call

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159176#comment-16159176 ] 

Hadoop QA commented on SENTRY-1921:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12886117/SENTRY-1921.001.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3266/console

This message is automatically generated.

> Make SentryServiceFactory.create static and all calling instances use the static call
> -------------------------------------------------------------------------------------
>
>                 Key: SENTRY-1921
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1921
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Service
>    Affects Versions: 2.0.0
>            Reporter: Brian Towles
>            Assignee: Jan Hentschel
>            Priority: Minor
>         Attachments: SENTRY-1921.001.patch
>
>
> The SentryServiceFactory.create call is not a static and all the references to the factory end up creating a new instance of the factory.   This should be turned into a static call.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)