[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24018: Make expand() error vague so it's not misleading

[GitBox <gi...@apache.org>]

ephraimbuddy commented on code in PR #24018:
URL: https://github.com/apache/airflow/pull/24018#discussion_r884574814


##########
airflow/models/mappedoperator.py:
##########
@@ -201,7 +201,7 @@ def _expand(self, **mapped_kwargs: "Mappable") -> "MappedOperator":
         from airflow.operators.empty import EmptyOperator
 
         validate_mapping_kwargs(self.operator_class, "expand", mapped_kwargs)
-        prevent_duplicates(self.kwargs, mapped_kwargs, fail_reason="mapping already partial")
+        prevent_duplicates(self.kwargs, mapped_kwargs, fail_reason="unmappable or already specified")

Review Comment:
   ```suggestion
           prevent_duplicates(self.kwargs, mapped_kwargs, fail_reason="unmappable or already specified.")
   ```
   Maybe a dot here? The error from the issue is difficult to read



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org