You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/11/29 14:29:32 UTC
[GitHub] [activemq] mattrpav commented on a diff in pull request #943: Added additional logging on BrokerService startup
mattrpav commented on code in PR #943:
URL: https://github.com/apache/activemq/pull/943#discussion_r1034824113
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -668,10 +668,13 @@ private void doStartPersistenceAdapter() throws Exception {
persistenceAdapterToStart.setBrokerName(getBrokerName());
LOG.info("Using Persistence Adapter: {}", persistenceAdapterToStart);
if (deleteAllMessagesOnStartup) {
+ LOG.info("Deleting all messages on startup because deleteAllMessagesOnStartup configuration has been provided");
deleteAllMessages();
}
+ LOG.info("Starting Persistence Adapter: {}", persistenceAdapterToStart);
persistenceAdapterToStart.start();
+ LOG.info("Starting Temp Data Store");
Review Comment:
Same here.. would be super useful to know how long it took to start and how many messages vs 'just.. i'm starting'
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -685,6 +688,7 @@ private void doStartPersistenceAdapter() throws Exception {
}
}
+ LOG.info("Starting Job Scheduler Store");
Review Comment:
This line shouldn't be logged, unless there is a job store configured, right? Same.. as the others.. I think a startup time plus # of messages is more useful.
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -668,10 +668,13 @@ private void doStartPersistenceAdapter() throws Exception {
persistenceAdapterToStart.setBrokerName(getBrokerName());
LOG.info("Using Persistence Adapter: {}", persistenceAdapterToStart);
if (deleteAllMessagesOnStartup) {
+ LOG.info("Deleting all messages on startup because deleteAllMessagesOnStartup configuration has been provided");
deleteAllMessages();
}
+ LOG.info("Starting Persistence Adapter: {}", persistenceAdapterToStart);
Review Comment:
This line seems redundant to L669. How about moving this to after the persistence completes and adding some statistics -- like how long it took or how many messages available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org