You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/04 03:10:21 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32766: [SPARK-35627][CORE] Decommission executors in batches to not overload network bandwidth
dongjoon-hyun commented on a change in pull request #32766:
URL: https://github.com/apache/spark/pull/32766#discussion_r645259464
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -2023,6 +2023,22 @@ package object config {
.stringConf
.createWithDefaultString("PWR")
+ private[spark] val EXECUTOR_DECOMMISSION_BATCH_INTERVAL =
+ ConfigBuilder("spark.executor.decommission.batchInterval")
+ .doc("Executors are decommissioned in batched to avoid overloading network bandwidth in" +
+ " migrating rdd and shuffle data. This config sets the interval between batches.")
+ .version("3.2.0")
+ .timeConf(TimeUnit.MILLISECONDS)
+ .createWithDefault(30000)
+
+ private[spark] val EXECUTOR_DECOMMISSION_BATCH_SIZE =
+ ConfigBuilder("spark.executor.decommission.batchSize")
+ .doc("Executors are decommissioned in batched to avoid overloading network bandwidth in" +
+ " migrating rdd and shuffle data. This config sets the interval between batches.")
Review comment:
`the interval between batches` looks like a typo because this is a batch size, not an interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org