You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Christian Grobmeier <gr...@gmail.com> on 2011/08/19 13:14:01 UTC
Removing the ant junit testing
We have discussed recently the sense of antrun doing junit test, bypassing mvn.
Curt mentioned that this probably has been done because of several
cleanup actions which were not made by mvn.
I have attached patch below, which comments the antrun for junit.
After this patch i could run mvn test and did not see a difference to
the previous solution. 237 tests were running, without failures. After
running it, I had one folder generated by the testing (output). With
antrun I had two which were not cleaned up for some reasons, output
and classes.
So it looks as it would work without ant.
My suggestion is as follows:
- apply the patch below
- mv tests/src/java to src/test/java (standard by mvn)
- mv tests/resources to src/test/resources (standard by mvn)
- move the test/input + witness files to src/test/resources
- change the test cases to generate their output into target/test-work/output
- remove the junit portions from ant buildfiles
After that we should have an easier testing process.
Any objections why we should not do that?
The only reason I could imagine is that 1.2.x series is going to die
soon. I am not sure if we should do the effort. For this question I
would love to hear some opions
Cheers
Christian
### Eclipse Workspace Patch 1.0
#P log4j-12-trunk
Index: pom.xml
===================================================================
--- pom.xml (revision 1159577)
+++ pom.xml (working copy)
@@ -100,7 +100,7 @@
<workingDirectory>tests</workingDirectory>
<reportFormat>plain</reportFormat>
<forkMode>pertest</forkMode>
- <skip>true</skip>
+ <skip>false</skip>
<includes>
<include>org/apache/log4j/LevelTest.java</include>
<include>org/apache/log4j/PriorityTest.java</include>
@@ -180,6 +180,7 @@
<version>1.2</version>
<executions>
<!-- generate NTEventLogAppender.dll -->
+ <!--
<execution>
<phase>process-classes</phase>
<id>ntdll</id>
@@ -197,7 +198,9 @@
<goal>run</goal>
</goals>
</execution>
+ -->
<!-- create tests/output prior to test run -->
+ <!--
<execution>
<phase>test-compile</phase>
<id>mkdir_tests_output</id>
@@ -239,6 +242,7 @@
<goal>run</goal>
</goals>
</execution>
+ -->
<!-- release builds will put SVN tags into the SCM page,
this changes it back to trunk -->
<execution>
<phase>site</phase>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: Removing the ant junit testing
Posted by Christian Grobmeier <gr...@gmail.com>.
I have commented it, because it does not build on my machine (mac).
But we can leave that in the pom. Any comments to the rest of my
message?
On Thu, Aug 25, 2011 at 5:22 AM, Curt Arnold <ca...@apache.org> wrote:
> This following patch would kill building NTEventAppender.dll which has been included in the distribution for the last couple releases (after being missing for several releases). There were several emphatic requests prior to the previous releases to also provide an x64 version of NTEventAppender which the current build process also provides.
>
>
> On Aug 19, 2011, at 6:14 AM, Christian Grobmeier wrote:
>
>> We have discussed recently the sense of antrun doing junit test, bypassing mvn.
>> Curt mentioned that this probably has been done because of several
>> cleanup actions which were not made by mvn.
>>
>> I have attached patch below, which comments the antrun for junit.
>> After this patch i could run mvn test and did not see a difference to
>> the previous solution. 237 tests were running, without failures. After
>> running it, I had one folder generated by the testing (output). With
>> antrun I had two which were not cleaned up for some reasons, output
>> and classes.
>>
>> So it looks as it would work without ant.
>>
>> My suggestion is as follows:
>>
>> - apply the patch below
>> - mv tests/src/java to src/test/java (standard by mvn)
>> - mv tests/resources to src/test/resources (standard by mvn)
>> - move the test/input + witness files to src/test/resources
>> - change the test cases to generate their output into target/test-work/output
>> - remove the junit portions from ant buildfiles
>>
>> After that we should have an easier testing process.
>>
>> Any objections why we should not do that?
>>
>> The only reason I could imagine is that 1.2.x series is going to die
>> soon. I am not sure if we should do the effort. For this question I
>> would love to hear some opions
>>
>> Cheers
>> Christian
>>
>>
>>
>>
>> ### Eclipse Workspace Patch 1.0
>> #P log4j-12-trunk
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml (revision 1159577)
>> +++ pom.xml (working copy)
>> @@ -100,7 +100,7 @@
>> <workingDirectory>tests</workingDirectory>
>> <reportFormat>plain</reportFormat>
>> <forkMode>pertest</forkMode>
>> - <skip>true</skip>
>> + <skip>false</skip>
>> <includes>
>> <include>org/apache/log4j/LevelTest.java</include>
>> <include>org/apache/log4j/PriorityTest.java</include>
>> @@ -180,6 +180,7 @@
>> <version>1.2</version>
>> <executions>
>> <!-- generate NTEventLogAppender.dll -->
>> + <!--
>> <execution>
>> <phase>process-classes</phase>
>> <id>ntdll</id>
>> @@ -197,7 +198,9 @@
>> <goal>run</goal>
>> </goals>
>> </execution>
>> + -->
>> <!-- create tests/output prior to test run -->
>> + <!--
>> <execution>
>> <phase>test-compile</phase>
>> <id>mkdir_tests_output</id>
>> @@ -239,6 +242,7 @@
>> <goal>run</goal>
>> </goals>
>> </execution>
>> + -->
>> <!-- release builds will put SVN tags into the SCM page,
>> this changes it back to trunk -->
>> <execution>
>> <phase>site</phase>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
http://www.grobmeier.de
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: Removing the ant junit testing
Posted by Curt Arnold <ca...@apache.org>.
This following patch would kill building NTEventAppender.dll which has been included in the distribution for the last couple releases (after being missing for several releases). There were several emphatic requests prior to the previous releases to also provide an x64 version of NTEventAppender which the current build process also provides.
On Aug 19, 2011, at 6:14 AM, Christian Grobmeier wrote:
> We have discussed recently the sense of antrun doing junit test, bypassing mvn.
> Curt mentioned that this probably has been done because of several
> cleanup actions which were not made by mvn.
>
> I have attached patch below, which comments the antrun for junit.
> After this patch i could run mvn test and did not see a difference to
> the previous solution. 237 tests were running, without failures. After
> running it, I had one folder generated by the testing (output). With
> antrun I had two which were not cleaned up for some reasons, output
> and classes.
>
> So it looks as it would work without ant.
>
> My suggestion is as follows:
>
> - apply the patch below
> - mv tests/src/java to src/test/java (standard by mvn)
> - mv tests/resources to src/test/resources (standard by mvn)
> - move the test/input + witness files to src/test/resources
> - change the test cases to generate their output into target/test-work/output
> - remove the junit portions from ant buildfiles
>
> After that we should have an easier testing process.
>
> Any objections why we should not do that?
>
> The only reason I could imagine is that 1.2.x series is going to die
> soon. I am not sure if we should do the effort. For this question I
> would love to hear some opions
>
> Cheers
> Christian
>
>
>
>
> ### Eclipse Workspace Patch 1.0
> #P log4j-12-trunk
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 1159577)
> +++ pom.xml (working copy)
> @@ -100,7 +100,7 @@
> <workingDirectory>tests</workingDirectory>
> <reportFormat>plain</reportFormat>
> <forkMode>pertest</forkMode>
> - <skip>true</skip>
> + <skip>false</skip>
> <includes>
> <include>org/apache/log4j/LevelTest.java</include>
> <include>org/apache/log4j/PriorityTest.java</include>
> @@ -180,6 +180,7 @@
> <version>1.2</version>
> <executions>
> <!-- generate NTEventLogAppender.dll -->
> + <!--
> <execution>
> <phase>process-classes</phase>
> <id>ntdll</id>
> @@ -197,7 +198,9 @@
> <goal>run</goal>
> </goals>
> </execution>
> + -->
> <!-- create tests/output prior to test run -->
> + <!--
> <execution>
> <phase>test-compile</phase>
> <id>mkdir_tests_output</id>
> @@ -239,6 +242,7 @@
> <goal>run</goal>
> </goals>
> </execution>
> + -->
> <!-- release builds will put SVN tags into the SCM page,
> this changes it back to trunk -->
> <execution>
> <phase>site</phase>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org