You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/06/26 20:03:55 UTC
Review Request 35934: New "Not Acceptable" HTTP response type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
Repository: mesos-incubating
Description
-------
Needed for HTTP API Call validation patches
Diffs
-----
3rdparty/libprocess/include/process/http.hpp 16f0a01
Diff: https://reviews.apache.org/r/35934/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 35934: New "Not Acceptable" HTTP response type
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/#review90130
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 1, 2015, 6:48 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35934/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 6:48 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Needed for HTTP API Call validation patches
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 16f0a01
>
> Diff: https://reviews.apache.org/r/35934/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 35934: New "Not Acceptable" HTTP response type
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/
-----------------------------------------------------------
(Updated July 1, 2015, 6:48 p.m.)
Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
Repository: mesos-incubating
Description
-------
Needed for HTTP API Call validation patches
Diffs
-----
3rdparty/libprocess/include/process/http.hpp 16f0a01
Diff: https://reviews.apache.org/r/35934/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 35934: New "Not Acceptable" HTTP response type
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/#review89582
-----------------------------------------------------------
As a general design note, we should have the `int code` as a separate attribute of the response (with the associated `statusCode()` getter) - this is what anyone would expect to have.
Can we please add that?
I would also like to see the `string message` to be disaggregated:
```
const int code = 401;
const string message = "Not Authorized";
```
so in the base class you just have:
```
string status()
{
return "" + code " " + message;
}
```
which is a much better (composable) design.
- Marco Massenzio
On June 26, 2015, 6:30 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35934/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 6:30 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Needed for HTTP API Call validation patches
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 16f0a01
>
> Diff: https://reviews.apache.org/r/35934/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 35934: New "Not Acceptable" HTTP response type
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/
-----------------------------------------------------------
(Updated June 26, 2015, 6:30 p.m.)
Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
Repository: mesos-incubating
Description
-------
Needed for HTTP API Call validation patches
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp 16f0a01
Diff: https://reviews.apache.org/r/35934/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 35934: New "Not Acceptable" HTTP response type
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/#review89534
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/http.hpp (line 444)
<https://reviews.apache.org/r/35934/#comment142159>
Minor : the response code is 406 for a not acceptable response.
- Anand Mazumdar
On June 26, 2015, 6:03 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35934/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 6:03 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Needed for HTTP API Call validation patches
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 16f0a01
>
> Diff: https://reviews.apache.org/r/35934/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>