Re: [I] String compare for Substrait roundtrip check [arrow-datafusion]

["tgujar (via GitHub)" <gi...@apache.org>]

tgujar commented on issue #8361:
URL: https://github.com/apache/arrow-datafusion/issues/8361#issuecomment-1840047758

   Plan 1 is the produced Logical plan, and Plan 2 is Plan1 converted to substrait and then converted back to Logical plan. I think the issue arises because of differences in what can be expressed by substrait grammar vs the logical plan generated by Datafusion. For tests where the plans differ I think using [assert_expected_plan](https://github.com/apache/arrow-datafusion/blob/aeb012e78115bf69d9a58407ac24bc20bd9e0bf0/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs#L781C10-L781C30) instead of [roundtrip_with_ctx](https://github.com/apache/arrow-datafusion/blob/aeb012e78115bf69d9a58407ac24bc20bd9e0bf0/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs#L832) should work after manual inspection. I think I want to look into this further but maybe we could normalize both plans somehow and then check for equality


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org