You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/11/21 12:03:45 UTC
[GitHub] couchdb-fauxton pull request: Doc design
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/161
Doc design
Opening this as I can't reopen https://github.com/apache/couchdb-fauxton/pull/151
This PR tries again to slice off small parts of 33 and my branch I created from 33
The goal is a faster and better review and a mergeable state as fauxton-master is a fast moving target. We merge parts of the branch iteratively and additionally refactor which is easier with small pieces. Smaller chunks also introduce less bugs as they can be tested more easy and the review does not take hours.
The plan: after this branch the select buttons are moving to the header:
I did not add the ability to hide the checkboxes - this is part of the next step where we have the toggle mechanism in the header. It is not a downgrade to the current functionality. I prepared everything so we can just remove the show-select class on a parent container to remove the checkboxes and to adjust the padding.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton doc-design
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/161.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #161
----
commit 1e0c6c1e9c2f8608846968fe5ab3eae939da115a
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-13T15:33:35Z
new design for docs
commit 79f3e277d48429a10f0552b67286c3607cffc2bd
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-13T16:45:50Z
wip
commit f39e053def0ee1544135452cf38efe3ddbc7b10e
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-13T17:03:15Z
easier customization
commit 9d1b02c96a76ac3e76a2a9691624f5c85f9941b8
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-13T21:33:47Z
styling: labels / checkboxes
commit 77ac4b0f264841c9b275e5ffd881414e479fc388
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-14T13:17:53Z
fix change event
commit 084fea8c2daf3dd32a93079b853fe8f8a9fc3947
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-14T14:29:45Z
show-select & select-all
commit 577445b5a2a13f4d159163b7cab98e01bd324311
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-14T14:57:04Z
whitespace
commit 11f96064bb12e214e726de3c29b7b6ba8799cd6b
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-18T13:49:50Z
change behaviour of select-all
commit 5d4c7f93f547b90d62cef8018fd44453cead2d22
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-19T13:48:03Z
fix test
commit 8a650dc34814c5e99c9809f84effaf663324777a
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-19T14:52:04Z
make other test green, fix things that came up while running the tests
commit f6995cd63b1517703507b34a63e7fe2e54945cf3
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-19T17:15:36Z
fix paging bug with active select-all button
commit baea3f94945696054a90d73481330ee7f594e502
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-19T17:18:32Z
fix unit test
commit b69aba701b4f48bb603466b5fb91f4773e8d33cc
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-19T17:20:42Z
hover
commit 80799cf478da2f2c4b6ca83122aa0711eaaca696
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-19T17:25:17Z
meh
commit 170fccffc029d0bcab086e5ea2acf75cee7f0ebb
Author: Robert Kowalski <ro...@apache.org>
Date: 2014-11-21T10:56:47Z
adjust font-size to 20px for pencil
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Doc design
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/161#issuecomment-64007696
+1 this looks great, @robertkowalski
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Doc design
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/161#issuecomment-64177822
landed as 715485799085ec8e332257e0c9ed5b2fca877d93 - whohoo!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Doc design
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/161#issuecomment-64029966
+1 !
Behavior works great.
Everything looks good.
one tiny thing...though,
in assets/less/variables.less line 77,
@docCheckBoxCheckedBorder: 2px solid #000;
the border looks a bit intense on my screen.
How about :
@docCheckBoxCheckedBorder: 2px solid #444;
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Doc design
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/161#issuecomment-64097985
@michellephung good catch! added the test!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Doc design
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Doc design
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/161#issuecomment-64034551
nightwatch_tests/custom-commands/createManyDocuments.js is missing from this branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Doc design
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/161#issuecomment-64170453
+1 merge it :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---