You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "akashsonune (via GitHub)" <gi...@apache.org> on 2025/01/24 17:56:13 UTC
[PR] fix(datazoom): prevent bar and scatter chart overflowing the graph . … [echarts]
akashsonune opened a new pull request, #20718:
URL: https://github.com/apache/echarts/pull/20718
…close #19972
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
The PR prevents bars and scatter chart from going outside of the graph when zoomed in
### Fixed issues
<!--
- #19972 ...
-->
## Details
### Before: What was the problem?
In case the filtermode: 'none' and series type is bar or scatter and x axiis type is time, on zooming in too much, the bars would go outside of the graph (beyond axis)
### After: How does it behave after the fixing?
The bars and scatter chart stays within the axis.
## Document Info
One of the following should be checked.
- [ ] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(datazoom): prevent bar and scatter chart overflowing the graph . … [echarts]
Posted by "100pah (via GitHub)" <gi...@apache.org>.
100pah commented on PR #20718:
URL: https://github.com/apache/echarts/pull/20718#issuecomment-4449579048
Many thanks for your investigating and fix.
The new v6.1.0 fixes this issue in a generic way instead of special handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(datazoom): prevent bar and scatter chart overflowing the graph . … [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #20718:
URL: https://github.com/apache/echarts/pull/20718#issuecomment-2613092221
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(datazoom): prevent bar and scatter chart overflowing the graph . … [echarts]
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on code in PR #20718:
URL: https://github.com/apache/echarts/pull/20718#discussion_r1986669507
##########
src/component/dataZoom/AxisProxy.ts:
##########
@@ -271,7 +271,22 @@ class AxisProxy {
const valueWindow = this._valueWindow;
if (filterMode === 'none') {
- return;
+ each(seriesModels, function (seriesModel) {
+ if (seriesModel.subType === 'bar' || seriesModel.subType === 'scatter') {
Review Comment:
It may not be a good idea to check `subType` here because AxisProxy should have no idea of what series type is. These logic should probably be implemented in their own series code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(datazoom): prevent bar and scatter chart overflowing the graph . … [echarts]
Posted by "akashsonune (via GitHub)" <gi...@apache.org>.
akashsonune commented on PR #20718:
URL: https://github.com/apache/echarts/pull/20718#issuecomment-2660887856
@Ovilia Can you take a look at the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(datazoom): prevent bar and scatter chart overflowing the graph . … [echarts]
Posted by "100pah (via GitHub)" <gi...@apache.org>.
100pah closed pull request #20718: fix(datazoom): prevent bar and scatter chart overflowing the graph . …
URL: https://github.com/apache/echarts/pull/20718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org