[GitHub] [phoenix] joshelser commented on a change in pull request #1074: PHOENIX-6305 Throttling decision does not take offheap memstore size …

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #1074:
URL: https://github.com/apache/phoenix/pull/1074#discussion_r554057411



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
##########
@@ -260,7 +260,9 @@ void commitBatch(Region region, List<Mutation> mutations, long blockingMemstoreS
        Mutation[] mutationArray = new Mutation[mutations.size()];
       // When memstore size reaches blockingMemstoreSize we are waiting 3 seconds for the
       // flush happen which decrease the memstore size and then writes allowed on the region.
-      for (int i = 0; blockingMemstoreSize > 0 && region.getMemStoreHeapSize() > blockingMemstoreSize && i < 30; i++) {
+      for (int i = 0; blockingMemstoreSize > 0
+              && region.getMemStoreHeapSize() + region.getMemStoreOffHeapSize() > blockingMemstoreSize

Review comment:
       If we're including offheap memstore size, do we need to be calculating the `blockingMemstoreSize` differently?
   
   It looks like we define it to be the table's `flushSize * (memstore_block_multiplier-1)`. I think this is still fine -- we're not changing how much memstore we hold on to, just whether that's on or off heap, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org