You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sangeeta Ravindran <sa...@gmail.com> on 2016/03/24 16:26:18 UTC
Review Request 45291: When saving repository changes,
confirm dialog shows message key instead of actual message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45291/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
Bugs: AMBARI-15551
https://issues.apache.org/jira/browse/AMBARI-15551
Repository: ambari
Description
-------
Click on Versions in the Ambari Admin view.
Click on the Repository version.
Delete a repository or edit the url for it.
Click on Save.
A confirming dialog pops up with the following message:
versions.changeBaseURLConfirmationTip.message
Fix involves using the correct message key.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 2c3f000
Diff: https://reviews.apache.org/r/45291/diff/
Testing
-------
Tested manually.
Thanks,
Sangeeta Ravindran
Re: Review Request 45291: When saving repository changes,
confirm dialog shows message key instead of actual message
Posted by Sangeeta Ravindran <sa...@gmail.com>.
> On March 24, 2016, 4:34 p.m., Alexandr Antonenko wrote:
> > Ship It!
Thanks Alexander. Can you please help push the fix.
- Sangeeta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45291/#review125277
-----------------------------------------------------------
On March 24, 2016, 3:27 p.m., Sangeeta Ravindran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45291/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 3:27 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
>
>
> Bugs: AMBARI-15551
> https://issues.apache.org/jira/browse/AMBARI-15551
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Click on Versions in the Ambari Admin view.
> Click on the Repository version.
> Delete a repository or edit the url for it.
> Click on Save.
> A confirming dialog pops up with the following message:
> versions.changeBaseURLConfirmationTip.message
>
> Fix involves using the correct message key.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 2c3f000
>
> Diff: https://reviews.apache.org/r/45291/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> File Attachments
> ----------------
>
> AMBARI-15551.patch
> https://reviews.apache.org/media/uploaded/files/2016/03/24/2bb8b0a6-489a-4b0d-bb34-a40a44c73acf__AMBARI-15551.patch
>
>
> Thanks,
>
> Sangeeta Ravindran
>
>
Re: Review Request 45291: When saving repository changes,
confirm dialog shows message key instead of actual message
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45291/#review125277
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On March 24, 2016, 3:27 p.m., Sangeeta Ravindran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45291/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 3:27 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
>
>
> Bugs: AMBARI-15551
> https://issues.apache.org/jira/browse/AMBARI-15551
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Click on Versions in the Ambari Admin view.
> Click on the Repository version.
> Delete a repository or edit the url for it.
> Click on Save.
> A confirming dialog pops up with the following message:
> versions.changeBaseURLConfirmationTip.message
>
> Fix involves using the correct message key.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 2c3f000
>
> Diff: https://reviews.apache.org/r/45291/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> File Attachments
> ----------------
>
> AMBARI-15551.patch
> https://reviews.apache.org/media/uploaded/files/2016/03/24/2bb8b0a6-489a-4b0d-bb34-a40a44c73acf__AMBARI-15551.patch
>
>
> Thanks,
>
> Sangeeta Ravindran
>
>
Re: Review Request 45291: When saving repository changes,
confirm dialog shows message key instead of actual message
Posted by Sangeeta Ravindran <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45291/
-----------------------------------------------------------
(Updated March 24, 2016, 3:27 p.m.)
Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
Bugs: AMBARI-15551
https://issues.apache.org/jira/browse/AMBARI-15551
Repository: ambari
Description
-------
Click on Versions in the Ambari Admin view.
Click on the Repository version.
Delete a repository or edit the url for it.
Click on Save.
A confirming dialog pops up with the following message:
versions.changeBaseURLConfirmationTip.message
Fix involves using the correct message key.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 2c3f000
Diff: https://reviews.apache.org/r/45291/diff/
Testing
-------
Tested manually.
File Attachments (updated)
----------------
AMBARI-15551.patch
https://reviews.apache.org/media/uploaded/files/2016/03/24/2bb8b0a6-489a-4b0d-bb34-a40a44c73acf__AMBARI-15551.patch
Thanks,
Sangeeta Ravindran