You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by mkby <gi...@git.apache.org> on 2017/01/06 06:39:59 UTC
[GitHub] incubator-trafodion pull request #906: [TRAFODION-2430] python installer - n...
GitHub user mkby opened a pull request:
https://github.com/apache/incubator-trafodion/pull/906
[TRAFODION-2430] python installer - need to modify Makefile for building a tar package
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkby/incubator-trafodion 2430
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/906.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #906
----
commit a5dd41d80c7f05b1d4c0148a4f86a77ef7758798
Author: Eason <hf...@gmail.com>
Date: 2017-01-06T06:35:32Z
[TRAFODION-2430] python installer - need to modify Makefile for building a tar package
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #906: [TRAFODION-2430] python installer - n...
Posted by svarnau <gi...@git.apache.org>.
Github user svarnau commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/906#discussion_r94908975
--- Diff: install/Makefile ---
@@ -17,28 +17,42 @@
RELEASE_VER ?= ${TRAFODION_VER}-incubating
RELEASE_TYPE ?= $(shell echo $(TRAFODION_VER_PROD)| sed -e 's/ /-/g')
INSTALLER_TARNAME = $(shell echo ${RELEASE_TYPE}_installer-${RELEASE_VER}.tar.gz |tr '[A-Z]' '[a-z]')
+PYINSTALLER_TARNAME = $(shell echo ${RELEASE_TYPE}_pyinstaller-${RELEASE_VER}.tar.gz |tr '[A-Z]' '[a-z]')
-all: pkg-installer
+all: pkg-installer
-pkg-installer: installer/LICENSE installer/NOTICE installer/DISCLAIMER
+pkg-installer: installer/LICENSE installer/NOTICE installer/DISCLAIMER \
+ python-installer/LICENSE python-installer/NOTICE python-installer/DISCLAIMER
tar czf ${INSTALLER_TARNAME} installer --exclude=tools
+ tar czf ${PYINSTALLER_TARNAME} python-installer
mkdir -p ../distribution
--- End diff --
Rather than build two tarballs in one makefile target, I think it would be cleaner to make another target, and have all target depend on both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #906: [TRAFODION-2430] python installer - n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/906
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---