You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/15 18:29:47 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1245: include/errno.h: Add ELAST macro definition
xiaoxiang781216 opened a new pull request #1245:
URL: https://github.com/apache/incubator-nuttx/pull/1245
like FreeBSD:
https://github.com/freebsd/freebsd/blob/master/sys/sys/errno.h
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
Change-Id: I89fc7e417a31e4890b31a6c2a3d4b910981482e1
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1245: include/errno.h: Add ELAST macro definition
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #1245:
URL: https://github.com/apache/incubator-nuttx/pull/1245#issuecomment-644487300
> I noticed that in FreeBSD that ELAST is wrapped in ''#ifndef _POSIX_SOURCE' nor is is specified on opengroup.org
Yes, ELAST doesn't specify in opengroup.org which is BSD libc extension, but some 3rd party library(e.g. libcxx: https://github.com/llvm-mirror/libcxx/blob/master/src/include/config_elast.h) use this value. If we want to keep other project change as small as possible, we have to add some extension like this. Since all other nonstandard API isn't conditional compiled in NuttX, I follow this convention here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #1245: include/errno.h: Add ELAST macro definition
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #1245:
URL: https://github.com/apache/incubator-nuttx/pull/1245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1245: include/errno.h: Add ELAST macro definition
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1245:
URL: https://github.com/apache/incubator-nuttx/pull/1245#issuecomment-644487300
> I noticed that in FreeBSD that ELAST is wrapped in ''#ifndef _POSIX_SOURCE' nor is is specified on opengroup.org
Yes, ELAST doesn't specify in opengroup.org which is BSD libc extension, but some 3rd party library(e.g. libcxx: https://github.com/llvm-mirror/libcxx/blob/master/src/include/config_elast.h) use this value. If we want to keep other project change as small as possible, we have to add some extension like this. Since all other nonstandard API isn't conditional compiled in nuttx.h, I follow this convention here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org