[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1619: Clarified application developer responsibility when using onException in native mode

[GitBox <gi...@apache.org>]

jamesnetherton commented on a change in pull request #1619:
URL: https://github.com/apache/camel-quarkus/pull/1619#discussion_r477192737



##########
File path: extensions/flatpack/deployment/src/main/java/org/apache/camel/quarkus/component/flatpack/deployment/FlatpackProcessor.java
##########
@@ -36,8 +34,4 @@ NativeImageResourceBuildItem registerNativeImageResources() {
         return new NativeImageResourceBuildItem("net/sf/flatpack/xml/flatpack.dtd", "fpconvert.properties");
     }
 
-    @BuildStep
-    ReflectiveClassBuildItem registerReflectiveClasses() {
-        return new ReflectiveClassBuildItem(false, false, FlatpackException.class);

Review comment:
       Maybe we should keep this?
   
   If it's a class provided by Camel, then I see no harm in the extension registering it for reflection. If the exception types are provided by the user application, then it seems reasonable that they need to register them for reflection manually. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org