You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhan Reddy <mr...@gmail.com> on 2017/01/11 06:26:44 UTC
Review Request 55405: AMBARI-19453. Dashboard should display
appropriate message if workflow data fetching api fails
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55405/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19453
https://issues.apache.org/jira/browse/AMBARI-19453
Repository: ambari
Description
-------
Dashboard should display appropriate message if workflow data fetching api fails. Currently dashboard shows empty table without any error message. This provides the user wrong impression that no workflow is being run. Instead its better to show error message explicitly.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js ddb19af
Diff: https://reviews.apache.org/r/55405/diff/
Testing
-------
Manual
Thanks,
Madhan Reddy
Re: Review Request 55405: AMBARI-19453. Dashboard should display
appropriate message if workflow data fetching api fails
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55405/#review161203
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Jan. 11, 2017, 6:26 a.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55405/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 6:26 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19453
> https://issues.apache.org/jira/browse/AMBARI-19453
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Dashboard should display appropriate message if workflow data fetching api fails. Currently dashboard shows empty table without any error message. This provides the user wrong impression that no workflow is being run. Instead its better to show error message explicitly.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js ddb19af
>
> Diff: https://reviews.apache.org/r/55405/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>
Re: Review Request 55405: AMBARI-19453. Dashboard should display
appropriate message if workflow data fetching api fails
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55405/#review161182
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Jan. 11, 2017, 6:26 a.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55405/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 6:26 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19453
> https://issues.apache.org/jira/browse/AMBARI-19453
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Dashboard should display appropriate message if workflow data fetching api fails. Currently dashboard shows empty table without any error message. This provides the user wrong impression that no workflow is being run. Instead its better to show error message explicitly.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js ddb19af
>
> Diff: https://reviews.apache.org/r/55405/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>