You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "hanghangliu (via GitHub)" <gi...@apache.org> on 2023/10/30 22:42:36 UTC
[PR] Make KafkaTopicGroupingWorkUnitPacker pack with desired num of container [gobblin]
hanghangliu opened a new pull request, #3814:
URL: https://github.com/apache/gobblin/pull/3814
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1936] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1936
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Make KafkaTopicGroupingWorkUnitPacker pick up the variable numContainers so that be able to pack with desired num of container.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Added test cases.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make KafkaTopicGroupingWorkUnitPacker pack with desired num of container [gobblin]
Posted by "ZihanLi58 (via GitHub)" <gi...@apache.org>.
ZihanLi58 merged PR #3814:
URL: https://github.com/apache/gobblin/pull/3814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make KafkaTopicGroupingWorkUnitPacker pack with desired num of container [gobblin]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3814:
URL: https://github.com/apache/gobblin/pull/3814#issuecomment-1800863709
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3814?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3814](https://app.codecov.io/gh/apache/gobblin/pull/3814?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3526f26) into [master](https://app.codecov.io/gh/apache/gobblin/commit/918716fbd7dcc4dfaef7071c058f7209d64e694b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (918716f) will **decrease** coverage by `1.70%`.
> Report is 15 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3814 +/- ##
============================================
- Coverage 47.68% 45.99% -1.70%
+ Complexity 11052 2181 -8871
============================================
Files 2155 416 -1739
Lines 85260 17984 -67276
Branches 9483 2194 -7289
============================================
- Hits 40656 8271 -32385
+ Misses 40919 8830 -32089
+ Partials 3685 883 -2802
```
[see 1749 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3814/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make KafkaTopicGroupingWorkUnitPacker pack with desired num of container [gobblin]
Posted by "ZihanLi58 (via GitHub)" <gi...@apache.org>.
ZihanLi58 commented on code in PR #3814:
URL: https://github.com/apache/gobblin/pull/3814#discussion_r1378260990
##########
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaTopicGroupingWorkUnitPacker.java:
##########
@@ -381,4 +391,40 @@ static double getContainerCapacityForTopic(List<Double> capacities, ContainerCap
throw new RuntimeException("Unsupported computation strategy: " + strategy.name());
}
}
+
+ /**
+ * A method that split a list of {@link MultiWorkUnit} to the size of desiredWUSize if possible. The split approach is to
Review Comment:
Add comments here to mention that we always try to split MWU with more partitions first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org