You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/18 09:21:43 UTC

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #4825: orchestration mode code optimization .

yu199195 opened a new pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825
 
 
   this is orchestration mode code optimization .
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394215956
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java
 ##########
 @@ -237,9 +236,9 @@ public boolean isShadowRule(final String shardingSchemaName) {
      */
     @SuppressWarnings("unchecked")
     public Map<String, DataSourceConfiguration> loadDataSourceConfigurations(final String shardingSchemaName) {
-        Map<String, YamlDataSourceConfiguration> result = (Map) YamlEngine.unmarshal(repository.get(node.getDataSourcePath(shardingSchemaName)));
+        Map<String, YamlDataSourceConfiguration> result = (Map<String, YamlDataSourceConfiguration>) YamlEngine.unmarshal(repository.get(node.getDataSourcePath(shardingSchemaName)));
 
 Review comment:
   unnecessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394213402
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java
 ##########
 @@ -228,7 +229,7 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
             }
             DataChangedEvent.ChangedType changedType = getChangedType(event);
             if (DataChangedEvent.ChangedType.IGNORED != changedType) {
-                dataChangedEventListener.onChange(new DataChangedEvent(data.getPath(), null == data.getData() ? null : new String(data.getData(), "UTF-8"), changedType));
+                dataChangedEventListener.onChange(new DataChangedEvent(data.getPath(), null == data.getData() ? null : new String(data.getData(), StandardCharsets.UTF_8), changedType));
 
 Review comment:
   unnecessary.
   a local static field is better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394212838
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-configuration/src/main/java/org/apache/shardingsphere/orchestration/center/yaml/swapper/OrchestrationConfigurationYamlSwapper.java
 ##########
 @@ -40,7 +40,7 @@
      */
     @Override
     public YamlOrchestrationConfiguration swap(final OrchestrationConfiguration configuration) {
-        Map<String, YamlCenterRepositoryConfiguration> yamlInstanceConfigurationMap = new HashMap();
+        Map<String, YamlCenterRepositoryConfiguration> yamlInstanceConfigurationMap = new HashMap<>();
 
 Review comment:
   why?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600566986
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=h1) Report
   > Merging [#4825](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6b5697580b3d5057249ecba57394f7ec07d60045&el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `46.15%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4825      +/-   ##
   ============================================
   - Coverage     56.38%   56.28%   -0.10%     
     Complexity      449      449              
   ============================================
     Files          1166     1166              
     Lines         20958    20939      -19     
     Branches       3884     3883       -1     
   ============================================
   - Hits          11817    11786      -31     
   - Misses         8415     8427      +12     
     Partials        726      726              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ter/instance/CuratorZookeeperCenterRepository.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckNlbnRlclJlcG9zaXRvcnkuamF2YQ==) | `65.81% <0.00%> (ø)` | `26.00 <0.00> (ø)` | |
   | [...ngsphere/orchestration/core/common/CenterType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbW1vbi9DZW50ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9Db25maWdDZW50ZXIuamF2YQ==) | `75.90% <40.00%> (+0.90%)` | `0.00 <0.00> (ø)` | |
   | [...center/listener/AuthenticationChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9BdXRoZW50aWNhdGlvbkNoYW5nZWRMaXN0ZW5lci5qYXZh) | `75.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...nfigcenter/listener/PropertiesChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9Qcm9wZXJ0aWVzQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `75.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...e/configcenter/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9TY2hlbWFDaGFuZ2VkTGlzdGVuZXIuamF2YQ==) | `72.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...enter/schema/OrchestrationShardingSchemaGroup.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLXJlZ2lzdHJ5Y2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvcmVnaXN0cnljZW50ZXIvc2NoZW1hL09yY2hlc3RyYXRpb25TaGFyZGluZ1NjaGVtYUdyb3VwLmphdmE=) | `100.00% <100.00%> (+10.00%)` | `0.00 <0.00> (ø)` | |
   | [...lying/common/config/TypeBasedSPIConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbmZpZy9UeXBlQmFzZWRTUElDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (ø%)` | |
   | [.../command/query/text/query/MySQLComQueryPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L3RleHQvcXVlcnkvTXlTUUxDb21RdWVyeVBhY2tldC5qYXZh) | `62.50% <0.00%> (-37.50%)` | `0.00% <0.00%> (ø%)` | |
   | [...ingscaling/mysql/binlog/MySQLNegotiateHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL015U1FMTmVnb3RpYXRlSGFuZGxlci5qYXZh) | `90.47% <0.00%> (-9.53%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=footer). Last update [6b56975...cc8ffde](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600566986
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=h1) Report
   > Merging [#4825](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6b5697580b3d5057249ecba57394f7ec07d60045?src=pr&el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `46.15%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master    #4825     +/-   ##
   ===========================================
   - Coverage     56.38%   56.28%   -0.1%     
     Complexity      449      449             
   ===========================================
     Files          1166     1166             
     Lines         20958    20939     -19     
     Branches       3884     3883      -1     
   ===========================================
   - Hits          11817    11786     -31     
   - Misses         8415     8427     +12     
     Partials        726      726
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ter/instance/CuratorZookeeperCenterRepository.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckNlbnRlclJlcG9zaXRvcnkuamF2YQ==) | `65.81% <0%> (ø)` | `26 <0> (ø)` | :arrow_down: |
   | [...ngsphere/orchestration/core/common/CenterType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbW1vbi9DZW50ZXJUeXBlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...nfigcenter/listener/PropertiesChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9Qcm9wZXJ0aWVzQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `75% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/configcenter/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9TY2hlbWFDaGFuZ2VkTGlzdGVuZXIuamF2YQ==) | `72% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...center/listener/AuthenticationChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9BdXRoZW50aWNhdGlvbkNoYW5nZWRMaXN0ZW5lci5qYXZh) | `75% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...enter/schema/OrchestrationShardingSchemaGroup.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLXJlZ2lzdHJ5Y2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvcmVnaXN0cnljZW50ZXIvc2NoZW1hL09yY2hlc3RyYXRpb25TaGFyZGluZ1NjaGVtYUdyb3VwLmphdmE=) | `100% <100%> (+10%)` | `0 <0> (ø)` | :arrow_down: |
   | [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9Db25maWdDZW50ZXIuamF2YQ==) | `75.9% <40%> (+0.9%)` | `0 <0> (ø)` | :arrow_down: |
   | [...lying/common/config/TypeBasedSPIConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbmZpZy9UeXBlQmFzZWRTUElDb25maWd1cmF0aW9uLmphdmE=) | `0% <0%> (-85.72%)` | `0% <0%> (ø)` | |
   | [.../command/query/text/query/MySQLComQueryPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L3RleHQvcXVlcnkvTXlTUUxDb21RdWVyeVBhY2tldC5qYXZh) | `62.5% <0%> (-37.5%)` | `0% <0%> (ø)` | |
   | [...ingscaling/mysql/binlog/MySQLNegotiateHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL015U1FMTmVnb3RpYXRlSGFuZGxlci5qYXZh) | `90.47% <0%> (-9.53%)` | `0% <0%> (ø)` | |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=footer). Last update [6b56975...715a456](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871
 
 
   ## Pull Request Test Coverage Report for [Build 10358](https://coveralls.io/builds/29442574)
   
   * **7** of **13**   **(53.85%)**  changed or added relevant lines in **7** files are covered.
   * **11** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.04%**) to **59.812%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java](https://coveralls.io/builds/29442574/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2FCenterType.java#L45) | 0 | 3 | 0.0%
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java](https://coveralls.io/builds/29442574/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2FConfigCenter.java#L183) | 2 | 5 | 40.0%
   <!-- | **Total:** | **7** | **13** | **53.85%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java](https://coveralls.io/builds/29442574/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2FConfigCenter.java#L189) | 1 | 91.57% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29442574/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/config/TypeBasedSPIConfiguration.java](https://coveralls.io/builds/29442574/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fconfig%2FTypeBasedSPIConfiguration.java#L37) | 7 | 0% |
   <!-- | **Total:** | **11** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29442574/badge)](https://coveralls.io/builds/29442574) |
   | :-- | --: |
   | Change from base [Build 1106](https://coveralls.io/builds/29439761): |  -0.04% |
   | Covered Lines: | 12524 |
   | Relevant Lines: | 20939 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600974093
 
 
   It is rather work-hard coding and reviewing from the thread of comments.
   Reviewing carefully @kimmking and polishing with patience @yu199195 made this PR so great. 👍 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394214986
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java
 ##########
 @@ -180,13 +180,12 @@ private void persistShardingSchemaName(final String shardingSchemaName) {
             repository.persist(node.getSchemaPath(), shardingSchemaName);
             return;
         }
-        List<String> schemaNameList = Splitter.on(",").splitToList(shardingSchemaNames);
+        List<String> schemaNameList = Lists.newArrayList(Splitter.on(",").split(shardingSchemaNames));
 
 Review comment:
   why?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394396209
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java
 ##########
 @@ -31,16 +32,18 @@
     
     REGISTRY_CENTER("registry_center"),
     CONFIG_CENTER("config_center");
-    
+
     private final String value;
-    
+
 
 Review comment:
   blank line should be with four space

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394214545
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java
 ##########
 @@ -41,6 +42,8 @@
      * @return OrchestrationType enum, return {@code null} if not found
      */
     public static CenterType findByValue(final String value) {
-        return Arrays.stream(CenterType.values()).filter(each -> each.getValue().equals(value)).findFirst().get();
+        return Arrays.stream(CenterType.values())
+                .filter(each -> each.getValue().equals(value)).findFirst()
+                .orElseThrow(() -> new OrchestrationException("now only support :{},{}", "registry_center", "config_center"));
 
 Review comment:
   good.
   but static field referred better than literal string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
yu199195 opened a new pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825
 
 
   this is orchestration mode code optimization .
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394395966
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java
 ##########
 @@ -86,7 +86,7 @@ private CuratorFramework buildCuratorClient(final CenterConfiguration config, fi
             builder.connectionTimeoutMs(operationTimeoutMilliseconds);
         }
         if (!Strings.isNullOrEmpty(digest)) {
-            builder.authorization("digest", digest.getBytes(Charsets.UTF_8))
+            builder.authorization("digest", digest.getBytes(StandardCharsets.UTF_8))
 
 Review comment:
   remove nio static, use local static field.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871
 
 
   ## Pull Request Test Coverage Report for [Build 10380](https://coveralls.io/builds/29461682)
   
   * **7** of **10**   **(70.0%)**  changed or added relevant lines in **7** files are covered.
   * **10** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.04%**) to **59.809%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java](https://coveralls.io/builds/29461682/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2FCenterType.java#L45) | 0 | 3 | 0.0%
   <!-- | **Total:** | **7** | **10** | **70.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29461682/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/config/TypeBasedSPIConfiguration.java](https://coveralls.io/builds/29461682/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fconfig%2FTypeBasedSPIConfiguration.java#L37) | 7 | 0% |
   <!-- | **Total:** | **10** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29461682/badge)](https://coveralls.io/builds/29461682) |
   | :-- | --: |
   | Change from base [Build 1106](https://coveralls.io/builds/29439761): |  -0.04% |
   | Covered Lines: | 12524 |
   | Relevant Lines: | 20940 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871
 
 
   ## Pull Request Test Coverage Report for [Build 10349](https://coveralls.io/builds/29440789)
   
   * **8** of **12**   **(66.67%)**  changed or added relevant lines in **7** files are covered.
   * **26** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.008%**) to **59.845%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java](https://coveralls.io/builds/29440789/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2FCenterType.java#L47) | 0 | 1 | 0.0%
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java](https://coveralls.io/builds/29440789/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2FConfigCenter.java#L183) | 3 | 6 | 50.0%
   <!-- | **Total:** | **8** | **12** | **66.67%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java](https://coveralls.io/builds/29440789/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2FConfigCenter.java#L189) | 1 | 91.57% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java](https://coveralls.io/builds/29440789/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2FCenterType.java#L45) | 2 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29440789/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java](https://coveralls.io/builds/29440789/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FCuratorZookeeperCenterRepository.java#L95) | 20 | 71.79% |
   <!-- | **Total:** | **26** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29440789/badge)](https://coveralls.io/builds/29440789) |
   | :-- | --: |
   | Change from base [Build 1106](https://coveralls.io/builds/29439761): |  -0.008% |
   | Covered Lines: | 12531 |
   | Relevant Lines: | 20939 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yu199195 closed pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
yu199195 closed pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600566986
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=h1) Report
   > Merging [#4825](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6b5697580b3d5057249ecba57394f7ec07d60045&el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4825      +/-   ##
   ============================================
   - Coverage     56.38%   56.28%   -0.10%     
     Complexity      449      449              
   ============================================
     Files          1166     1166              
     Lines         20958    20940      -18     
     Branches       3884     3883       -1     
   ============================================
   - Hits          11817    11786      -31     
   - Misses         8415     8428      +13     
     Partials        726      726              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ter/instance/CuratorZookeeperCenterRepository.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckNlbnRlclJlcG9zaXRvcnkuamF2YQ==) | `65.81% <0.00%> (ø)` | `26.00 <0.00> (ø)` | |
   | [...ngsphere/orchestration/core/common/CenterType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbW1vbi9DZW50ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9Db25maWdDZW50ZXIuamF2YQ==) | `75.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...center/listener/AuthenticationChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9BdXRoZW50aWNhdGlvbkNoYW5nZWRMaXN0ZW5lci5qYXZh) | `75.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...nfigcenter/listener/PropertiesChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9Qcm9wZXJ0aWVzQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `75.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...e/configcenter/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9TY2hlbWFDaGFuZ2VkTGlzdGVuZXIuamF2YQ==) | `72.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...enter/schema/OrchestrationShardingSchemaGroup.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLXJlZ2lzdHJ5Y2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvcmVnaXN0cnljZW50ZXIvc2NoZW1hL09yY2hlc3RyYXRpb25TaGFyZGluZ1NjaGVtYUdyb3VwLmphdmE=) | `100.00% <100.00%> (+10.00%)` | `0.00 <0.00> (ø)` | |
   | [...lying/common/config/TypeBasedSPIConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbmZpZy9UeXBlQmFzZWRTUElDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (ø%)` | |
   | [.../command/query/text/query/MySQLComQueryPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L3RleHQvcXVlcnkvTXlTUUxDb21RdWVyeVBhY2tldC5qYXZh) | `62.50% <0.00%> (-37.50%)` | `0.00% <0.00%> (ø%)` | |
   | [...ingscaling/mysql/binlog/MySQLNegotiateHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL015U1FMTmVnb3RpYXRlSGFuZGxlci5qYXZh) | `90.47% <0.00%> (-9.53%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=footer). Last update [6b56975...a671792](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871
 
 
   ## Pull Request Test Coverage Report for [Build 10366](https://coveralls.io/builds/29445688)
   
   * **13** of **19**   **(68.42%)**  changed or added relevant lines in **7** files are covered.
   * **11** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.04%**) to **59.812%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java](https://coveralls.io/builds/29445688/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2FCenterType.java#L45) | 0 | 3 | 0.0%
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java](https://coveralls.io/builds/29445688/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2FConfigCenter.java#L183) | 2 | 5 | 40.0%
   <!-- | **Total:** | **13** | **19** | **68.42%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java](https://coveralls.io/builds/29445688/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2FConfigCenter.java#L189) | 1 | 91.57% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29445688/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/config/TypeBasedSPIConfiguration.java](https://coveralls.io/builds/29445688/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fconfig%2FTypeBasedSPIConfiguration.java#L37) | 7 | 0% |
   <!-- | **Total:** | **11** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29445688/badge)](https://coveralls.io/builds/29445688) |
   | :-- | --: |
   | Change from base [Build 1106](https://coveralls.io/builds/29439761): |  -0.04% |
   | Covered Lines: | 12524 |
   | Relevant Lines: | 20939 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394315244
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java
 ##########
 @@ -228,7 +228,7 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
             }
             DataChangedEvent.ChangedType changedType = getChangedType(event);
             if (DataChangedEvent.ChangedType.IGNORED != changedType) {
-                dataChangedEventListener.onChange(new DataChangedEvent(data.getPath(), null == data.getData() ? null : new String(data.getData(), "UTF-8"), changedType));
+                dataChangedEventListener.onChange(new DataChangedEvent(data.getPath(), null == data.getData() ? null : new String(data.getData(), Charsets.UTF_8), changedType));
 
 Review comment:
   don't refer guava

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871
 
 
   ## Pull Request Test Coverage Report for [Build 10378](https://coveralls.io/builds/29461242)
   
   * **6** of **9**   **(66.67%)**  changed or added relevant lines in **7** files are covered.
   * **11** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.04%**) to **59.812%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java](https://coveralls.io/builds/29461242/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2FCenterType.java#L45) | 0 | 3 | 0.0%
   <!-- | **Total:** | **6** | **9** | **66.67%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java](https://coveralls.io/builds/29461242/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2FConfigCenter.java#L199) | 1 | 91.57% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29461242/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/config/TypeBasedSPIConfiguration.java](https://coveralls.io/builds/29461242/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fconfig%2FTypeBasedSPIConfiguration.java#L37) | 7 | 0% |
   <!-- | **Total:** | **11** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29461242/badge)](https://coveralls.io/builds/29461242) |
   | :-- | --: |
   | Change from base [Build 1106](https://coveralls.io/builds/29439761): |  -0.04% |
   | Covered Lines: | 12524 |
   | Relevant Lines: | 20939 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871
 
 
   ## Pull Request Test Coverage Report for [Build 10374](https://coveralls.io/builds/29460260)
   
   * **7** of **13**   **(53.85%)**  changed or added relevant lines in **7** files are covered.
   * **11** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.04%**) to **59.812%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java](https://coveralls.io/builds/29460260/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2FCenterType.java#L45) | 0 | 3 | 0.0%
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java](https://coveralls.io/builds/29460260/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2FConfigCenter.java#L183) | 2 | 5 | 40.0%
   <!-- | **Total:** | **7** | **13** | **53.85%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java](https://coveralls.io/builds/29460260/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-configcenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fconfigcenter%2FConfigCenter.java#L189) | 1 | 91.57% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29460260/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/config/TypeBasedSPIConfiguration.java](https://coveralls.io/builds/29460260/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fconfig%2FTypeBasedSPIConfiguration.java#L37) | 7 | 0% |
   <!-- | **Total:** | **11** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29460260/badge)](https://coveralls.io/builds/29460260) |
   | :-- | --: |
   | Change from base [Build 1106](https://coveralls.io/builds/29439761): |  -0.04% |
   | Covered Lines: | 12524 |
   | Relevant Lines: | 20939 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
yu199195 opened a new pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825
 
 
   this is orchestration mode code optimization .
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394314389
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java
 ##########
 @@ -31,7 +32,7 @@
     
     REGISTRY_CENTER("registry_center"),
     CONFIG_CENTER("config_center");
-    
+
 
 Review comment:
   blank line should be with four space

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yu199195 closed pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
yu199195 closed pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] yu199195 commented on a change in pull request #4825: orchestration mode code optimization .

Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394231745
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java
 ##########
 @@ -180,13 +180,12 @@ private void persistShardingSchemaName(final String shardingSchemaName) {
             repository.persist(node.getSchemaPath(), shardingSchemaName);
             return;
         }
-        List<String> schemaNameList = Splitter.on(",").splitToList(shardingSchemaNames);
+        List<String> schemaNameList = Lists.newArrayList(Splitter.on(",").split(shardingSchemaNames));
 
 Review comment:
   splitToList return readOnly List,and Then the list will add,

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services