You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/05/29 18:05:23 UTC
[GitHub] [geode] dschneider-pivotal opened a new pull request #5184: change more string commands to have CommandFunction support
dschneider-pivotal opened a new pull request #5184:
URL: https://github.com/apache/geode/pull/5184
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-640956507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-642879687
`INCRBYFLOAT` gives the following error and the `redis-cli` exits. It works fine in native redis:
```
127.0.0.1:6379> incrbyfloat foo 1.1
Error: Protocol error, got "4" as reply type byte
```
However, when I reconnect `foo` appears to have been incremented correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-642220727
This pull request **introduces 1 alert** and **fixes 2** when merging 346a7f77f663231f90604471163f0ae63576190f into ece3a5a6c045075509a5097054e33a64d4194fae - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-233f6e2180642ded3cdae9f6c0e9b638c73fd5ed)
**new alerts:**
* 1 for Dereferenced variable may be null
**fixed alerts:**
* 1 for Useless comparison test
* 1 for Array index out of bounds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-644223347
the upgrade test failure is a known issue unrelated to this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-639188005
This pull request **fixes 1 alert** when merging 7cb9765300b7751d4059f33d728c252fd3ddfaba into 41f3d4e6b1c8a10eb22940683ccd100ac654432b - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-e66bd81311742a31ac0485086ddddfb300b9856e)
**fixed alerts:**
* 1 for Useless comparison test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-638458123
This pull request **fixes 1 alert** when merging 1a628f9dfde75b07f255459186f0e2f9eebc17cf into 62e7c54c05a1ee025596d6c36da262e2bd35bb8e - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-dc6c4c04c42ada241c6fc2086ecd78906612eba0)
**fixed alerts:**
* 1 for Useless comparison test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-641661187
This pull request **introduces 1 alert** and **fixes 1** when merging abe17b54947526839bd5cee9b74c75395a4156a0 into f65ea452443bcd2d0dac6ef1d2d958b0cb02936f - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-04301dda992b46e2405d6ea12ec94ad9a696f902)
**new alerts:**
* 1 for Dereferenced variable may be null
**fixed alerts:**
* 1 for Useless comparison test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-637362054
This pull request **fixes 1 alert** when merging e04f4fbfe8da7a6b10751c0fffedf4ca27daf75c into 57cc3c7b40816bc1b7bbae80481dea608c7caff5 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-2a87db012cf12692d85aebb92897aab89aa22491)
**fixed alerts:**
* 1 for Useless comparison test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-642819605
This pull request **fixes 2 alerts** when merging 08f2b923f688a0dd3e50b2b29ff5400a6b0f4dbb into 4a0eeeb57ccfa59ace909b55b6f228deac7621cf - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-4e9d7fb84acaef6e6d3d54b3fc892f485d1c39df)
**fixed alerts:**
* 1 for Useless comparison test
* 1 for Array index out of bounds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-642860272
This pull request **fixes 2 alerts** when merging 59c4b94d56ba4ccdc1c473f57fef0cf4d0e02478 into 4a0eeeb57ccfa59ace909b55b6f228deac7621cf - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-311a77d59154a1d47650b977bf5f8475349fc72f)
**fixed alerts:**
* 1 for Useless comparison test
* 1 for Array index out of bounds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-642992518
I fixed the issues Jens found and added integration tests for all these string commands
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-643088101
This pull request **fixes 2 alerts** when merging 549e874e40bc76a91ae1b23a3352e89be4e75498 into cb5990cd437244bc0ac8abdc6e12552e686e7c7a - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-15afa550bccfbd7a7758588029ca7c15a53cdf41)
**fixed alerts:**
* 1 for Useless comparison test
* 1 for Array index out of bounds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-642875100
I was trying some string OPs and saw this with `BITOP NOT`:
```
java.lang.ClassCastException: org.apache.geode.internal.cache.LocalDataSet cannot be cast to org.apache.geode.internal.cache.InternalRegion
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.internal.cache.execute.InternalFunctionExecutionServiceImpl.isClientRegion(InternalFunctionExecutionSe
rviceImpl.java:400)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.internal.cache.execute.InternalFunctionExecutionServiceImpl.onRegion(InternalFunctionExecutionServiceI
mpl.java:146)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.cache.execute.FunctionService.onRegion(FunctionService.java:76)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.redis.internal.executor.CommandFunction.execute(CommandFunction.java:52)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.redis.internal.executor.string.RedisStringCommandsFunctionExecutor.get(RedisStringCommandsFunctionExec
utor.java:57)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.redis.internal.data.RedisStringInRegion.bitop(RedisStringInRegion.java:177)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.redis.internal.executor.CommandFunction.lambda$compute$19(CommandFunction.java:177)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.redis.internal.executor.CommandFunction.compute(CommandFunction.java:335)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.redis.internal.executor.SingleResultRedisFunction.lambda$execute$0(SingleResultRedisFunction.java:51)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.internal.cache.PartitionedRegion.computeWithPrimaryLocked(PartitionedRegion.java:631)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.redis.internal.executor.SingleResultRedisFunction.computeWithPrimaryLocked(SingleResultRedisFunction.j
ava:71)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.redis.internal.executor.SingleResultRedisFunction.execute(SingleResultRedisFunction.java:55)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.internal.cache.PartitionedRegionDataStore.executeOnDataStore(PartitionedRegionDataStore.java:2996)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.operateOnPartitionedRegion(PartitionedRegionFunctionStreamingMessage.java:101)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.internal.cache.partitioned.PartitionMessage.process(PartitionMessage.java:333)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:441)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.distributed.internal.ClusterOperationExecutors.runUntilShutdown(ClusterOperationExecutors.java:442)
at Remote Member '192.168.1.5(server2:78554)<v2>:41002' in org.apache.geode.distributed.internal.ClusterOperationExecutors.doFunctionExecutionThread(ClusterOperationExecutors.java:377)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-643018762
This pull request **fixes 2 alerts** when merging 5d237f81857b60b8ccf1bd8611c5ce3c984c8c3c into cb5990cd437244bc0ac8abdc6e12552e686e7c7a - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-06b39755eacf4cba083b2cc3504ccd1c1c0c63ba)
**fixed alerts:**
* 1 for Useless comparison test
* 1 for Array index out of bounds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-638482278
This pull request **fixes 1 alert** when merging a63a9424cb43ddd2142d4b8928f8a0f80c5c5f16 into 1d71714f45ceabaea93482bbe161dc34e7f8db22 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-d50f50856c8dc315c192a518b7890efa6dc00a9c)
**fixed alerts:**
* 1 for Useless comparison test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-641633868
This pull request **fixes 1 alert** when merging 1fb60c9be2e83e6efaac9686e0c30f1093578aec into 6e65b075351cf25f36c6023edc6b6608e48bf257 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-ac7f6ea5b09662a4512a67f07ad25dd77c65b68f)
**fixed alerts:**
* 1 for Useless comparison test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal merged pull request #5184: GEODE-8249: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal merged pull request #5184:
URL: https://github.com/apache/geode/pull/5184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5184: change more string commands to have CommandFunction support
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5184:
URL: https://github.com/apache/geode/pull/5184#issuecomment-642341679
This pull request **introduces 1 alert** and **fixes 2** when merging dd4c87ef0451f8de77ef8b7f8ad75dee3b9ec718 into 3a2cf76b77be63f2a67df1901fe5b588cdc2c94a - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-2c93bf39e8e01a909e0ce770b1807b649df2ac32)
**new alerts:**
* 1 for Dereferenced variable may be null
**fixed alerts:**
* 1 for Useless comparison test
* 1 for Array index out of bounds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org