You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/12/06 19:54:22 UTC

[GitHub] [superset] ktmud commented on a diff in pull request #22332: chore(datasets): Add /api/v1/dataset/{pk}/column endpoint

ktmud commented on code in PR #22332:
URL: https://github.com/apache/superset/pull/22332#discussion_r1041389148


##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ColumnSelect.tsx:
##########
@@ -98,17 +98,17 @@ export function ColumnSelect({
     }
     if (datasetId != null) {
       cachedSupersetGet({
-        endpoint: `/api/v1/dataset/${datasetId}`,
+        endpoint: `/api/v1/dataset/${datasetId}/column`,

Review Comment:
   ```suggestion
           endpoint: `/api/v1/dataset/${datasetId}/columns`,
   ```
   
   Should this end point be `/columns`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org