You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/05/14 19:20:05 UTC

[GitHub] [helix] jiajunwang commented on pull request #974: Enforce result check for data accessors batch get calls to prevent partial batch read.

jiajunwang commented on pull request #974:
URL: https://github.com/apache/helix/pull/974#issuecomment-628838174


   > There are too many places that previously read partial data but now thrown exception. We need to reason for each case that when exception thrown, what is the difference of behavior and what should be right behavior.
   
   I believe, on the contrary, we need a reason for each case that does not throw an exception. The partial reads cause many problems. We need to be very strict.
   Moreover, the batch retry logic has been checked in to ensure connectivity issues won't be a concern anymore.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org