You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/16 07:58:23 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #37914: [SPARK-40471][BUILD] Upgrade RoaringBitmap to 0.9.32
LuciferYang opened a new pull request, #37914:
URL: https://github.com/apache/spark/pull/37914
### What changes were proposed in this pull request?
This pr aims upgrade RoaringBitmap 0.9.32
### Why are the changes needed?
This is a bug fix version:
- https://github.com/RoaringBitmap/RoaringBitmap/issues/575
- https://github.com/RoaringBitmap/RoaringBitmap/pull/578
other changes as follows:
- https://github.com/RoaringBitmap/RoaringBitmap/compare/0.9.31...0.9.32
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #37914: [SPARK-40471][BUILD] Upgrade RoaringBitmap to 0.9.32
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #37914: [SPARK-40471][BUILD] Upgrade RoaringBitmap to 0.9.32
URL: https://github.com/apache/spark/pull/37914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #37914: [SPARK-40471][BUILD] Upgrade RoaringBitmap to 0.9.32
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #37914:
URL: https://github.com/apache/spark/pull/37914#discussion_r972829440
##########
core/benchmarks/MapStatusesConvertBenchmark-results.txt:
##########
@@ -2,12 +2,12 @@
MapStatuses Convert Benchmark
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_332-b09 on Linux 5.13.0-1031-azure
+OpenJDK 64-Bit Server VM 1.8.0_345-b01 on Linux 5.15.0-1019-azure
Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
MapStatuses Convert: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-Num Maps: 50000 Fetch partitions:500 1001 1033 36 0.0 1000638934.0 1.0X
-Num Maps: 50000 Fetch partitions:1000 1699 1705 7 0.0 1699358972.0 0.6X
-Num Maps: 50000 Fetch partitions:1500 2647 2855 314 0.0 2646904255.0 0.4X
+Num Maps: 50000 Fetch partitions:500 1179 1187 13 0.0 1178581948.0 1.0X
Review Comment:
Let me double check the base data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #37914: [SPARK-40471][BUILD] Upgrade RoaringBitmap to 0.9.32
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #37914:
URL: https://github.com/apache/spark/pull/37914#discussion_r972970682
##########
core/benchmarks/MapStatusesConvertBenchmark-results.txt:
##########
@@ -2,12 +2,12 @@
MapStatuses Convert Benchmark
================================================================================================
-OpenJDK 64-Bit Server VM 1.8.0_332-b09 on Linux 5.13.0-1031-azure
+OpenJDK 64-Bit Server VM 1.8.0_345-b01 on Linux 5.15.0-1019-azure
Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
MapStatuses Convert: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-Num Maps: 50000 Fetch partitions:500 1001 1033 36 0.0 1000638934.0 1.0X
-Num Maps: 50000 Fetch partitions:1000 1699 1705 7 0.0 1699358972.0 0.6X
-Num Maps: 50000 Fetch partitions:1500 2647 2855 314 0.0 2646904255.0 0.4X
+Num Maps: 50000 Fetch partitions:500 1179 1187 13 0.0 1178581948.0 1.0X
Review Comment:
run this bench without this pr
```
================================================================================================
MapStatuses Convert Benchmark
================================================================================================
OpenJDK 64-Bit Server VM 1.8.0_345-b01 on Linux 5.15.0-1019-azure
Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
MapStatuses Convert: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
Num Maps: 50000 Fetch partitions:500 1150 1156 5 0.0 1149981444.0 1.0X
Num Maps: 50000 Fetch partitions:1000 2304 2322 18 0.0 2304318021.0 0.5X
Num Maps: 50000 Fetch partitions:1500 3557 3792 377 0.0 3556704966.0 0.3X
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37914: [SPARK-40471][BUILD] Upgrade RoaringBitmap to 0.9.32
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37914:
URL: https://github.com/apache/spark/pull/37914#issuecomment-1249044491
will check MapStatusesConvertBenchmark result later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org