You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/26 23:43:32 UTC

[GitHub] [spark] PedroCorreiaLuis opened a new pull request #26268: Fix SPARK-29594: Create a Dataset from a Sequence of Case class where a field name started with a number

PedroCorreiaLuis opened a new pull request #26268: Fix SPARK-29594: Create a Dataset from a Sequence of Case class where a field name started with a number
URL: https://github.com/apache/spark/pull/26268
 
 
   ### What changes were proposed in this pull request?
   This pr is to fix a bug discovered by me, [SPARK-29594], when creating a Dataset using .toDS() in a sequence of a case class that had a field name starting with a number.
   Also changed the behaviour when it is a java keyword now toDS() handles it.
   
   
   ### Why are the changes needed?
   Bug fix
   
   
   ### Does this PR introduce any user-facing change?
   Yes, now it is possible to create Datasets from case classes with field names as java keywords
   
   
   ### How was this patch tested?
   Tests were modified, but following the new logic: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org