You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2011/05/10 12:05:34 UTC

svn commit: r1101392 - /james/mailet/maven-mailetdocs-plugin/trunk/src/main/java/org/apache/james/mailet/DefaultDescriptorsExtractor.java

Author: rdonkin
Date: Tue May 10 10:05:34 2011
New Revision: 1101392

URL: http://svn.apache.org/viewvc?rev=1101392&view=rev
Log:
MAILETDOCS-3 Update more code to generics.

Modified:
    james/mailet/maven-mailetdocs-plugin/trunk/src/main/java/org/apache/james/mailet/DefaultDescriptorsExtractor.java

Modified: james/mailet/maven-mailetdocs-plugin/trunk/src/main/java/org/apache/james/mailet/DefaultDescriptorsExtractor.java
URL: http://svn.apache.org/viewvc/james/mailet/maven-mailetdocs-plugin/trunk/src/main/java/org/apache/james/mailet/DefaultDescriptorsExtractor.java?rev=1101392&r1=1101391&r2=1101392&view=diff
==============================================================================
--- james/mailet/maven-mailetdocs-plugin/trunk/src/main/java/org/apache/james/mailet/DefaultDescriptorsExtractor.java (original)
+++ james/mailet/maven-mailetdocs-plugin/trunk/src/main/java/org/apache/james/mailet/DefaultDescriptorsExtractor.java Tue May 10 10:05:34 2011
@@ -32,6 +32,7 @@ import java.util.Set;
 import org.apache.james.mailet.MailetMatcherDescriptor.Type;
 import org.apache.mailet.Mailet;
 import org.apache.mailet.Matcher;
+import org.apache.maven.artifact.Artifact;
 import org.apache.maven.artifact.DependencyResolutionRequiredException;
 import org.apache.maven.plugin.logging.Log;
 import org.apache.maven.project.MavenProject;
@@ -98,7 +99,7 @@ public class DefaultDescriptorsExtractor
                 res.add(descriptor);
             } else if (allInterfaces.size() > 0) {
                 for (int k = 0; k < allInterfaces.size(); k++) {
-                    log.debug("I: " + ((Class) allInterfaces.get(k)).getName());
+                    log.debug("I: " + ((Class<?>) allInterfaces.get(k)).getName());
                 }
             } else {
                 log.debug("No interfaces for " + klass.getName());
@@ -150,8 +151,7 @@ public class DefaultDescriptorsExtractor
         result.setType(type);
 
         final Object instance = klass.newInstance();
-        final String info = (String) klass.getMethod(
-                infoMethodName, null).invoke(instance, null);
+        final String info = (String) klass.getMethod(infoMethodName).invoke(instance);
         if (info != null && info.length() > 0) {
             result.setInfo(info);
         }
@@ -199,6 +199,7 @@ public class DefaultDescriptorsExtractor
     private URLClassLoader classLoader(MavenProject project, Log log) {
         URLClassLoader classLoader = null;
         try {
+            @SuppressWarnings("unchecked")
             final List<String> cpes = project.getCompileClasspathElements();
             final int size = cpes.size();
             final URL[] urls = new URL[size];
@@ -221,7 +222,8 @@ public class DefaultDescriptorsExtractor
 
     private JavaClass[] javaClasses(MavenProject project) {
         JavaDocBuilder builder = new JavaDocBuilder();
-        for (Iterator<String> i = project.getCompileSourceRoots().iterator(); i
+        for (@SuppressWarnings("unchecked")
+        Iterator<String> i = project.getCompileSourceRoots().iterator(); i
                 .hasNext();) {
             builder.addSourceTree(new File(i.next()));
         }
@@ -239,10 +241,11 @@ public class DefaultDescriptorsExtractor
 
     private void logProjectDependencies(MavenProject project, Log log) {
         if (log.isDebugEnabled()) {
-            final Set dependencies = project.getDependencyArtifacts();
+            @SuppressWarnings("unchecked")
+            final Set<Artifact> dependencies = project.getDependencyArtifacts();
             if (dependencies != null) {
-                for (final Iterator i = dependencies.iterator(); i.hasNext();) {
-                    log.debug("DEP: " + i.next());
+                for (final Artifact artifact: dependencies) {
+                    log.debug("DEP: " + artifact);
                 }
             }
         }



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org