You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by WeichenXu123 <gi...@git.apache.org> on 2018/01/12 00:42:46 UTC
[GitHub] spark pull request #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder p...
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/20241
[SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python API deprecated
## What changes were proposed in this pull request?
mark OneHotEncoder python API deprecated
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WeichenXu123/spark mark_ohe_deprecated
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20241
----
commit 895ef2017d668b48404e14a2a414d0eb3bb8cf87
Author: WeichenXu <we...@...>
Date: 2018-01-12T00:41:19Z
init pr
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python A...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20241
**[Test build #86004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86004/testReport)** for PR 20241 at commit [`895ef20`](https://github.com/apache/spark/commit/895ef2017d668b48404e14a2a414d0eb3bb8cf87).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder p...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20241#discussion_r161116898
--- Diff: python/pyspark/ml/feature.py ---
@@ -1577,6 +1577,8 @@ class OneHotEncoder(JavaTransformer, HasInputCol, HasOutputCol, JavaMLReadable,
.. note:: This is different from scikit-learn's OneHotEncoder,
which keeps all categories. The output vectors are sparse.
+ Deprecated in 2.3.0. ``OneHotEncoderEstimator`` will be renamed ``OneHotEncoder`` and this
--- End diff --
:py:class:`OneHotEncoderEstimator ` and :py:class:`OneHotEncoder`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder p...
Posted by MrBago <gi...@git.apache.org>.
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20241#discussion_r161116909
--- Diff: python/pyspark/ml/feature.py ---
@@ -1577,6 +1577,8 @@ class OneHotEncoder(JavaTransformer, HasInputCol, HasOutputCol, JavaMLReadable,
.. note:: This is different from scikit-learn's OneHotEncoder,
which keeps all categories. The output vectors are sparse.
+ Deprecated in 2.3.0. ``OneHotEncoderEstimator`` will be renamed ``OneHotEncoder`` and this
+ ``OneHotEncoder`` will be removed in 3.0.0..
--- End diff --
Also should this be a separate note?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20241
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86006/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20241
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20241
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86004/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python A...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20241
**[Test build #86006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86006/testReport)** for PR 20241 at commit [`1a77869`](https://github.com/apache/spark/commit/1a77869cbd1840200341f008f9f097f9a6e12c08).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20241
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python A...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/20241
LGTM thanks. Merged to master / branch-2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python A...
Posted by 6high <gi...@git.apache.org>.
Github user 6high commented on the issue:
https://github.com/apache/spark/pull/20241
good
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python A...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20241
**[Test build #86006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86006/testReport)** for PR 20241 at commit [`1a77869`](https://github.com/apache/spark/commit/1a77869cbd1840200341f008f9f097f9a6e12c08).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20241
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20241: [SPARK-23008][ML][FOLLOW-UP] mark OneHotEncoder python A...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20241
**[Test build #86004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86004/testReport)** for PR 20241 at commit [`895ef20`](https://github.com/apache/spark/commit/895ef2017d668b48404e14a2a414d0eb3bb8cf87).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org