You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by dong wang <el...@gmail.com> on 2015/03/06 08:56:28 UTC
some little questions about kylin
1, in common/src/main/java/org/apache/kylin/common/KylinConfig.java
public long getJobStepTimeout() {
return Long.parseLong(getOptional("kylin.job.step.timeout",
String.valueOf(2 * 60 * 60)));
}
it seems that the timeout is fixed, for some cases, the job step may takes
much more time than 2hrs, could we put this in some config file?
2, in script/download-tomcat.sh
since we compare STRING instead of NUMBER, thus, is it more reasonable to
change
from:
if [ ! `md5sum apache-tomcat-7.0.59.tar.gz | awk '{print $1}'` -eq
"ec570258976edf9a833cd88fd9220909" ]
to
if [ `md5sum apache-tomcat-7.0.59.tar.gz | awk '{print $1}'` !=
"ec570258976edf9a833cd88fd9220909" ]
Re: some little questions about kylin
Posted by "Zhou, Qianhao" <qi...@ebay.com>.
Hi, dong
Your contribution will be welcomed.
If you are interested, you can create a pull request in github.
Best Regard
Zhou QianHao
On 3/6/15, 3:56 PM, "dong wang" <el...@gmail.com> wrote:
>1, in common/src/main/java/org/apache/kylin/common/KylinConfig.java
> public long getJobStepTimeout() {
> return Long.parseLong(getOptional("kylin.job.step.timeout",
>String.valueOf(2 * 60 * 60)));
> }
>
>it seems that the timeout is fixed, for some cases, the job step may takes
>much more time than 2hrs, could we put this in some config file?
>
>
>2, in script/download-tomcat.sh
>since we compare STRING instead of NUMBER, thus, is it more reasonable to
>change
>from:
>if [ ! `md5sum apache-tomcat-7.0.59.tar.gz | awk '{print $1}'` -eq
>"ec570258976edf9a833cd88fd9220909" ]
>
>to
>
>if [ `md5sum apache-tomcat-7.0.59.tar.gz | awk '{print $1}'` !=
>"ec570258976edf9a833cd88fd9220909" ]
Re: some little questions about kylin
Posted by hongbin ma <ma...@apache.org>.
#1: it's not fixed, if you look at the getOptional() API, it will try to
find the "kylin.job.step.timeout" property in kylin.properties, and will
use 2 * 60 * 60 in case not found.
#2: please send a pull request
On Fri, Mar 6, 2015 at 3:56 PM, dong wang <el...@gmail.com> wrote:
> 1, in common/src/main/java/org/apache/kylin/common/KylinConfig.java
> public long getJobStepTimeout() {
> return Long.parseLong(getOptional("kylin.job.step.timeout",
> String.valueOf(2 * 60 * 60)));
> }
>
> it seems that the timeout is fixed, for some cases, the job step may takes
> much more time than 2hrs, could we put this in some config file?
>
>
> 2, in script/download-tomcat.sh
> since we compare STRING instead of NUMBER, thus, is it more reasonable to
> change
> from:
> if [ ! `md5sum apache-tomcat-7.0.59.tar.gz | awk '{print $1}'` -eq
> "ec570258976edf9a833cd88fd9220909" ]
>
> to
>
> if [ `md5sum apache-tomcat-7.0.59.tar.gz | awk '{print $1}'` !=
> "ec570258976edf9a833cd88fd9220909" ]
>