FooConstraint.jar Source

[Josh Elser <jo...@gmail.com>]

I'm working through ShellServerTest and noticed we have two jars that 
are used for testing.

'test/src/test/resources/FooFilter.jar' contains a class file and the 
java source file, but 'test/src/test/resources/FooConstraint.jar' only 
contains a class file.

Is the source for this class somewhere that I missed? I can't find it 
elsewhere in the tree.

Re: FooConstraint.jar Source

[Keith Turner <ke...@deenlo.com>]

On Wed, Nov 20, 2013 at 12:30 PM, Mike Drob <md...@mdrob.com> wrote:

> Does not having the source run us afoul of ASF policy?
>

I don't know, but I agree w/ Josh that it should be fixed before release.
 At the very least the Constraint jar should have source like the Filter
jar.   I used javap to disassemble FooFitler.class and I think it lines up
w/ the source.


>
>
> On Wed, Nov 20, 2013 at 12:25 PM, Josh Elser <jo...@gmail.com> wrote:
>
> > Yup to both. We definitely need to address this before we make the next
> > release of Accumulo.
> >
> >
> > On 11/20/13, 11:44 AM, Keith Turner wrote:
> >
> >> On Wed, Nov 20, 2013 at 11:33 AM, Sean Busbey <
> busbey+ml@clouderagovt.com
> >> >wrote:
> >>
> >>  Sounds like we need a ticket to reimplement that class.
> >>>
> >>> Fair to mark as newbie?
> >>>
> >>>
> >> Creating the source is certainly trivial.  Making maven build the jar
> for
> >> the test, I am not sure how easy that is.  It certainly needs a ticket.
> >>
> >>
> >>
> >>>
> >>> On Wed, Nov 20, 2013 at 9:32 AM, Keith Turner <ke...@deenlo.com>
> wrote:
> >>>
> >>>  I don't think the source was ever in source control.  Just the jar.
> >>>>
> >>>>
> >>>> On Tue, Nov 19, 2013 at 10:31 PM, Josh Elser <jo...@gmail.com>
> >>>>
> >>> wrote:
> >>>
> >>>>
> >>>>  I'm working through ShellServerTest and noticed we have two jars that
> >>>>>
> >>>> are
> >>>
> >>>> used for testing.
> >>>>>
> >>>>> 'test/src/test/resources/FooFilter.jar' contains a class file and the
> >>>>> java source file, but 'test/src/test/resources/FooConstraint.jar'
> only
> >>>>> contains a class file.
> >>>>>
> >>>>> Is the source for this class somewhere that I missed? I can't find it
> >>>>> elsewhere in the tree.
> >>>>>
> >>>>>
> >>>>
> >>>
> >>>
> >>> --
> >>> Sean
> >>>
> >>>
> >>
>

Re: FooConstraint.jar Source

[Billie Rinaldi <bi...@gmail.com>]

On Wed, Nov 20, 2013 at 10:19 AM, Josh Elser <jo...@gmail.com> wrote:

> AFAIK, yes. We are not distributing the complete source which is a no-no.


In my opinion, these files are binary blobs that we use to test the source
we're distributing, like the sample RFiles also in our source tree.  (There
are actually several more jars used as test resources, not just those
two.)  I'm in favor of including the source in the jars.  If we can figure
out a better way of doing the testing that doesn't involve pre-compiled
jars, I'm in favor of that too; but if we can't, I don't consider this a
blocker.

On 11/20/13, 12:30 PM, Mike Drob wrote:

> Does not having the source run us afoul of ASF policy?
>
>
> On Wed, Nov 20, 2013 at 12:25 PM, Josh Elser <jo...@gmail.com> wrote:
>
>  Yup to both. We definitely need to address this before we make the next
>> release of Accumulo.
>>
>>
>> On 11/20/13, 11:44 AM, Keith Turner wrote:
>>
>>  On Wed, Nov 20, 2013 at 11:33 AM, Sean Busbey <
>>> busbey+ml@clouderagovt.com
>>>
>>>> wrote:
>>>>
>>>
>>>   Sounds like we need a ticket to reimplement that class.
>>>
>>>>
>>>> Fair to mark as newbie?
>>>>
>>>>
>>>>  Creating the source is certainly trivial.  Making maven build the jar
>>> for
>>> the test, I am not sure how easy that is.  It certainly needs a ticket.
>>>
>>>
>>>
>>>
>>>> On Wed, Nov 20, 2013 at 9:32 AM, Keith Turner <ke...@deenlo.com> wrote:
>>>>
>>>>   I don't think the source was ever in source control.  Just the jar.
>>>>
>>>>>
>>>>>
>>>>> On Tue, Nov 19, 2013 at 10:31 PM, Josh Elser <jo...@gmail.com>
>>>>>
>>>>>  wrote:
>>>>
>>>>
>>>>>   I'm working through ShellServerTest and noticed we have two jars that
>>>>>
>>>>>>
>>>>>>  are
>>>>>
>>>>
>>>>  used for testing.
>>>>>
>>>>>>
>>>>>> 'test/src/test/resources/FooFilter.jar' contains a class file and the
>>>>>> java source file, but 'test/src/test/resources/FooConstraint.jar' only
>>>>>> contains a class file.
>>>>>>
>>>>>> Is the source for this class somewhere that I missed? I can't find it
>>>>>> elsewhere in the tree.
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Sean
>>>>
>>>>
>>>>
>>>
>

Re: FooConstraint.jar Source

[Josh Elser <jo...@gmail.com>]

AFAIK, yes. We are not distributing the complete source which is a no-no.

On 11/20/13, 12:30 PM, Mike Drob wrote:
> Does not having the source run us afoul of ASF policy?
>
>
> On Wed, Nov 20, 2013 at 12:25 PM, Josh Elser <jo...@gmail.com> wrote:
>
>> Yup to both. We definitely need to address this before we make the next
>> release of Accumulo.
>>
>>
>> On 11/20/13, 11:44 AM, Keith Turner wrote:
>>
>>> On Wed, Nov 20, 2013 at 11:33 AM, Sean Busbey <busbey+ml@clouderagovt.com
>>>> wrote:
>>>
>>>   Sounds like we need a ticket to reimplement that class.
>>>>
>>>> Fair to mark as newbie?
>>>>
>>>>
>>> Creating the source is certainly trivial.  Making maven build the jar for
>>> the test, I am not sure how easy that is.  It certainly needs a ticket.
>>>
>>>
>>>
>>>>
>>>> On Wed, Nov 20, 2013 at 9:32 AM, Keith Turner <ke...@deenlo.com> wrote:
>>>>
>>>>   I don't think the source was ever in source control.  Just the jar.
>>>>>
>>>>>
>>>>> On Tue, Nov 19, 2013 at 10:31 PM, Josh Elser <jo...@gmail.com>
>>>>>
>>>> wrote:
>>>>
>>>>>
>>>>>   I'm working through ShellServerTest and noticed we have two jars that
>>>>>>
>>>>> are
>>>>
>>>>> used for testing.
>>>>>>
>>>>>> 'test/src/test/resources/FooFilter.jar' contains a class file and the
>>>>>> java source file, but 'test/src/test/resources/FooConstraint.jar' only
>>>>>> contains a class file.
>>>>>>
>>>>>> Is the source for this class somewhere that I missed? I can't find it
>>>>>> elsewhere in the tree.
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Sean
>>>>
>>>>
>>>
>

Re: FooConstraint.jar Source

[Mike Drob <md...@mdrob.com>]

Does not having the source run us afoul of ASF policy?


On Wed, Nov 20, 2013 at 12:25 PM, Josh Elser <jo...@gmail.com> wrote:

> Yup to both. We definitely need to address this before we make the next
> release of Accumulo.
>
>
> On 11/20/13, 11:44 AM, Keith Turner wrote:
>
>> On Wed, Nov 20, 2013 at 11:33 AM, Sean Busbey <busbey+ml@clouderagovt.com
>> >wrote:
>>
>>  Sounds like we need a ticket to reimplement that class.
>>>
>>> Fair to mark as newbie?
>>>
>>>
>> Creating the source is certainly trivial.  Making maven build the jar for
>> the test, I am not sure how easy that is.  It certainly needs a ticket.
>>
>>
>>
>>>
>>> On Wed, Nov 20, 2013 at 9:32 AM, Keith Turner <ke...@deenlo.com> wrote:
>>>
>>>  I don't think the source was ever in source control.  Just the jar.
>>>>
>>>>
>>>> On Tue, Nov 19, 2013 at 10:31 PM, Josh Elser <jo...@gmail.com>
>>>>
>>> wrote:
>>>
>>>>
>>>>  I'm working through ShellServerTest and noticed we have two jars that
>>>>>
>>>> are
>>>
>>>> used for testing.
>>>>>
>>>>> 'test/src/test/resources/FooFilter.jar' contains a class file and the
>>>>> java source file, but 'test/src/test/resources/FooConstraint.jar' only
>>>>> contains a class file.
>>>>>
>>>>> Is the source for this class somewhere that I missed? I can't find it
>>>>> elsewhere in the tree.
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Sean
>>>
>>>
>>

Re: FooConstraint.jar Source

[Josh Elser <jo...@gmail.com>]

Yup to both. We definitely need to address this before we make the next 
release of Accumulo.

On 11/20/13, 11:44 AM, Keith Turner wrote:
> On Wed, Nov 20, 2013 at 11:33 AM, Sean Busbey <bu...@clouderagovt.com>wrote:
>
>> Sounds like we need a ticket to reimplement that class.
>>
>> Fair to mark as newbie?
>>
>
> Creating the source is certainly trivial.  Making maven build the jar for
> the test, I am not sure how easy that is.  It certainly needs a ticket.
>
>
>>
>>
>> On Wed, Nov 20, 2013 at 9:32 AM, Keith Turner <ke...@deenlo.com> wrote:
>>
>>> I don't think the source was ever in source control.  Just the jar.
>>>
>>>
>>> On Tue, Nov 19, 2013 at 10:31 PM, Josh Elser <jo...@gmail.com>
>> wrote:
>>>
>>>> I'm working through ShellServerTest and noticed we have two jars that
>> are
>>>> used for testing.
>>>>
>>>> 'test/src/test/resources/FooFilter.jar' contains a class file and the
>>>> java source file, but 'test/src/test/resources/FooConstraint.jar' only
>>>> contains a class file.
>>>>
>>>> Is the source for this class somewhere that I missed? I can't find it
>>>> elsewhere in the tree.
>>>>
>>>
>>
>>
>>
>> --
>> Sean
>>
>

Re: FooConstraint.jar Source

[Keith Turner <ke...@deenlo.com>]

On Wed, Nov 20, 2013 at 11:33 AM, Sean Busbey <bu...@clouderagovt.com>wrote:

> Sounds like we need a ticket to reimplement that class.
>
> Fair to mark as newbie?
>

Creating the source is certainly trivial.  Making maven build the jar for
the test, I am not sure how easy that is.  It certainly needs a ticket.


>
>
> On Wed, Nov 20, 2013 at 9:32 AM, Keith Turner <ke...@deenlo.com> wrote:
>
> > I don't think the source was ever in source control.  Just the jar.
> >
> >
> > On Tue, Nov 19, 2013 at 10:31 PM, Josh Elser <jo...@gmail.com>
> wrote:
> >
> > > I'm working through ShellServerTest and noticed we have two jars that
> are
> > > used for testing.
> > >
> > > 'test/src/test/resources/FooFilter.jar' contains a class file and the
> > > java source file, but 'test/src/test/resources/FooConstraint.jar' only
> > > contains a class file.
> > >
> > > Is the source for this class somewhere that I missed? I can't find it
> > > elsewhere in the tree.
> > >
> >
>
>
>
> --
> Sean
>

Re: FooConstraint.jar Source

[Sean Busbey <bu...@clouderagovt.com>]

Sounds like we need a ticket to reimplement that class.

Fair to mark as newbie?


On Wed, Nov 20, 2013 at 9:32 AM, Keith Turner <ke...@deenlo.com> wrote:

> I don't think the source was ever in source control.  Just the jar.
>
>
> On Tue, Nov 19, 2013 at 10:31 PM, Josh Elser <jo...@gmail.com> wrote:
>
> > I'm working through ShellServerTest and noticed we have two jars that are
> > used for testing.
> >
> > 'test/src/test/resources/FooFilter.jar' contains a class file and the
> > java source file, but 'test/src/test/resources/FooConstraint.jar' only
> > contains a class file.
> >
> > Is the source for this class somewhere that I missed? I can't find it
> > elsewhere in the tree.
> >
>



-- 
Sean

Re: FooConstraint.jar Source

[Keith Turner <ke...@deenlo.com>]

I don't think the source was ever in source control.  Just the jar.


On Tue, Nov 19, 2013 at 10:31 PM, Josh Elser <jo...@gmail.com> wrote:

> I'm working through ShellServerTest and noticed we have two jars that are
> used for testing.
>
> 'test/src/test/resources/FooFilter.jar' contains a class file and the
> java source file, but 'test/src/test/resources/FooConstraint.jar' only
> contains a class file.
>
> Is the source for this class somewhere that I missed? I can't find it
> elsewhere in the tree.
>