You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by et...@apache.org on 2024/03/12 12:13:56 UTC
(incubator-celeborn) branch main updated: [CELEBORN-1326] FakedRemoteInputChannel use task name of RemoteShuffleInputGateDelegation as owningTaskName

This is an automated email from the ASF dual-hosted git repository.

ethanfeng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new a03b7b5a6 [CELEBORN-1326] FakedRemoteInputChannel use task name of RemoteShuffleInputGateDelegation as owningTaskName
a03b7b5a6 is described below

commit a03b7b5a665f03f114422c8ba9be72d02d1e6772
Author: SteNicholas <pr...@163.com>
AuthorDate: Tue Mar 12 20:13:28 2024 +0800

    [CELEBORN-1326] FakedRemoteInputChannel use task name of RemoteShuffleInputGateDelegation as owningTaskName
    
    ### What changes were proposed in this pull request?
    
    `FakedRemoteInputChannel` use task name of `RemoteShuffleInputGateDelegation` as `owningTaskName` to get the task name from log of `SingleInputGate`.
    
    ### Why are the changes needed?
    
    `FakedRemoteInputChannel` use empty string as `owningTaskName`, which could not get the task name from the log of `SingleInputGate`, which could support using task name of `RemoteShuffleInputGateDelegation` as `owningTaskName`.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    CI.
    
    Closes #2384 from SteNicholas/CELEBORN-1326.
    
    Authored-by: SteNicholas <pr...@163.com>
    Signed-off-by: mingji <fe...@alibaba-inc.com>
---
 .../java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java   | 2 +-
 .../java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java   | 2 +-
 .../java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java   | 2 +-
 .../java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java b/client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
index c652f65d2..284e45818 100644
--- a/client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
+++ b/client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
@@ -199,7 +199,7 @@ public class RemoteShuffleInputGate extends IndexedInputGate {
     FakedRemoteInputChannel(int channelIndex) {
       super(
           new SingleInputGate(
-              "",
+              inputGateDelegation.getTaskName(),
               inputGateDelegation.getGateIndex(),
               new IntermediateDataSetID(),
               ResultPartitionType.BLOCKING,
diff --git a/client-flink/flink-1.15/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java b/client-flink/flink-1.15/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
index 161d90d48..425c3536f 100644
--- a/client-flink/flink-1.15/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
+++ b/client-flink/flink-1.15/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
@@ -211,7 +211,7 @@ public class RemoteShuffleInputGate extends IndexedInputGate {
     FakedRemoteInputChannel(int channelIndex) {
       super(
           new SingleInputGate(
-              "",
+              inputGateDelegation.getTaskName(),
               inputGateDelegation.getGateIndex(),
               new IntermediateDataSetID(),
               ResultPartitionType.BLOCKING,
diff --git a/client-flink/flink-1.17/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java b/client-flink/flink-1.17/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
index 7437162a4..20545696b 100644
--- a/client-flink/flink-1.17/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
+++ b/client-flink/flink-1.17/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
@@ -211,7 +211,7 @@ public class RemoteShuffleInputGate extends IndexedInputGate {
     FakedRemoteInputChannel(int channelIndex) {
       super(
           new SingleInputGate(
-              "",
+              inputGateDelegation.getTaskName(),
               inputGateDelegation.getGateIndex(),
               new IntermediateDataSetID(),
               ResultPartitionType.BLOCKING,
diff --git a/client-flink/flink-1.18/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java b/client-flink/flink-1.18/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
index 3e73ae91e..d04f7182f 100644
--- a/client-flink/flink-1.18/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
+++ b/client-flink/flink-1.18/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleInputGate.java
@@ -214,7 +214,7 @@ public class RemoteShuffleInputGate extends IndexedInputGate {
       // [FLINK-31642][network] Introduce the MemoryTierConsumerAgent to TieredStorageConsumerClient
       super(
           new SingleInputGate(
-              "",
+              inputGateDelegation.getTaskName(),
               inputGateDelegation.getGateIndex(),
               new IntermediateDataSetID(),
               ResultPartitionType.BLOCKING,