[jira] [Commented] (ZOOKEEPER-2470) ServerConfig#parse(String[]) ignores tickTime

["Edward Ribeiro (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655061#comment-15655061 ] 

Edward Ribeiro commented on ZOOKEEPER-2470:
-------------------------------------------

Hey [~shralex], it would be really cool if we got this patch patch merged. :) Would you mind to open a Github PR with your patch and maybe close the https://github.com/apache/zookeeper/pull/74 (it was the original solution as you pointed out at ZOOKEEPER-2472, but the PR looks fishy...)

Cheers!

> ServerConfig#parse(String[])  ignores tickTime
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-2470
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.7, 3.5.1
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Trivial
>             Fix For: 3.4.10, 3.5.3
>
>         Attachments: ZOOKEEPER-2470.patch
>
>
> Based on bug report from ykgarfield:
> ServerConfig#parse(String[]) method has the following code:
>     public void parse(String[] args) {
>         ...
>         if (args.length == 3) {
>                 tickTime = Integer.parseInt(args[2]);
>         }
>         if (args.length == 4) {
>                 maxClientCnxns = Integer.parseInt(args[3]);
>         }
>     }
>     ```
> So if args.length == 4 tickTime isn't parsed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)