You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/11/01 05:18:26 UTC
[kudu-CR] [util] Fix comment of faststring
lingbinlb@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 )
Change subject: [util] Fix comment of faststring
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/14604/1/src/kudu/util/faststring.h
File src/kudu/util/faststring.h:
http://gerrit.cloudera.org:8080/#/c/14604/1/src/kudu/util/faststring.h@239
PS1, Line 239: GrowByAtLeast(len_ + count - capacity_);
> Looks like this change broke a bunch of tests.
This is a bit weird. I checked several failed test cases, they are all in the python dir, and they all encountered NETWORK_ERROR,
such as
http://jenkins.kudu.apache.org/job/kudu-gerrit/19382/BUILD_TYPE=DEBUG/testReport/junit/kudu.tests.test_client/TestClient/test_alter_column/
and
http://jenkins.kudu.apache.org/job/kudu-gerrit/19382/BUILD_TYPE=DEBUG/testReport/junit/kudu.tests.test_client/TestClient/test_alter_table_add_drop_column/
So it looks like there was an accidental running environment problem, let me trigger jenkins again
--
To view, visit http://gerrit.cloudera.org:8080/14604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4bd4f31216fdf5cfbf70526f1358824fbda225a
Gerrit-Change-Number: 14604
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Nov 2019 05:18:26 +0000
Gerrit-HasComments: Yes